content/renderer/media/rtc_peer_connection_handler.h - Issue 2631433002: Rename RTCPeerConnection.updateIce to setConfiguration and make it work.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/media/rtc_peer_connection_handler.h

Issue 2631433002: Rename RTCPeerConnection.updateIce to setConfiguration and make it work. (Closed)

Patch Set: Simplifying signature of WebRTCPeerConnectionHandler::setConfiguration. Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/renderer/media/rtc_peer_connection_handler.h

diff --git a/content/renderer/media/rtc_peer_connection_handler.h b/content/renderer/media/rtc_peer_connection_handler.h

index cc179dcd339e2cd1333c93a83a83479c5e466961..1deeb9e5e5c9f44de64fc86b5b454b4deebf17fb 100644

--- a/content/renderer/media/rtc_peer_connection_handler.h

+++ b/content/renderer/media/rtc_peer_connection_handler.h

@@ -132,7 +132,7 @@ class CONTENT_EXPORT RTCPeerConnectionHandler

blink::WebRTCSessionDescription localDescription() override;

blink::WebRTCSessionDescription remoteDescription() override;

- bool setConfiguration(

+ blink::WebRTCErrorType setConfiguration(

const blink::WebRTCConfiguration& configuration) override;

bool addICECandidate(const blink::WebRTCICECandidate& candidate) override;

bool addICECandidate(const blink::WebRTCVoidRequest& request,