Rename RTCPeerConnection.updateIce to setConfiguration and make it work.

third_party/WebKit/public/platform/WebRTCPeerConnectionHandler.h

 /*
  * Copyright (C) 2012 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 23 matching lines @@
 #include "WebRTCStats.h"
 
 namespace blink {
 
 class WebMediaConstraints;
 class WebMediaStream;
 class WebMediaStreamTrack;
 class WebRTCAnswerOptions;
 class WebRTCDTMFSenderHandler;
 class WebRTCDataChannelHandler;
+class WebRTCError;
 class WebRTCICECandidate;
 class WebRTCOfferOptions;
 class WebRTCSessionDescription;
 class WebRTCSessionDescriptionRequest;
 class WebRTCStatsRequest;
 class WebRTCVoidRequest;
 class WebString;
 struct WebRTCConfiguration;
 struct WebRTCDataChannelInit;
 
@@ skipping 11 matching lines @@
   virtual void createAnswer(const WebRTCSessionDescriptionRequest&,
                             const WebMediaConstraints&) = 0;
   virtual void createAnswer(const WebRTCSessionDescriptionRequest&,
                             const WebRTCAnswerOptions&) = 0;
   virtual void setLocalDescription(const WebRTCVoidRequest&,
                                    const WebRTCSessionDescription&) = 0;
   virtual void setRemoteDescription(const WebRTCVoidRequest&,
                                     const WebRTCSessionDescription&) = 0;
   virtual WebRTCSessionDescription localDescription() = 0;
   virtual WebRTCSessionDescription remoteDescription() = 0;
-  virtual bool setConfiguration(const WebRTCConfiguration&) = 0;
+  virtual bool setConfiguration(const WebRTCConfiguration&, WebRTCError&) = 0;

[dcheng, 2017/01/13 23:10:38]

My personal feeling is it'd feel natural for this to just return WebRTCErrorType
directly, rather than having to keep the bool and error enum in sync. WDYT?

[Taylor_Brandstetter, 2017/01/14 00:08:40]

You're right. It's an output parameter in webrtc mainly for backwards
compatibility, but we don't have that restriction here. Done.

 
   // DEPRECATED
   virtual bool addICECandidate(const WebRTCICECandidate&) { return false; }
 
   virtual bool addICECandidate(const WebRTCVoidRequest&,
                                const WebRTCICECandidate&) {
     return false;
   }
   virtual bool addStream(const WebMediaStream&, const WebMediaConstraints&) = 0;
   virtual void removeStream(const WebMediaStream&) = 0;
   virtual void getStats(const WebRTCStatsRequest&) = 0;
   // Gets stats using the new stats collection API, see
   // third_party/webrtc/api/stats/.  These will replace the old stats collection
   // API when the new API has matured enough.
   virtual void getStats(std::unique_ptr<WebRTCStatsReportCallback>) = 0;
   virtual WebRTCDataChannelHandler* createDataChannel(
       const WebString& label,
       const WebRTCDataChannelInit&) = 0;
   virtual WebRTCDTMFSenderHandler* createDTMFSender(
       const WebMediaStreamTrack&) = 0;
   virtual void stop() = 0;
 };
 
 }  // namespace blink
 
 #endif  // WebRTCPeerConnectionHandler_h