Rename RTCPeerConnection.updateIce to setConfiguration and make it work.

third_party/WebKit/Source/modules/peerconnection/RTCPeerConnection.cpp

 /*
  * Copyright (C) 2012 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  *
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
@@ skipping 68 matching lines @@
 #include "platform/peerconnection/RTCOfferOptionsPlatform.h"
 #include "public/platform/Platform.h"
 #include "public/platform/WebCryptoAlgorithmParams.h"
 #include "public/platform/WebMediaStream.h"
 #include "public/platform/WebRTCAnswerOptions.h"
 #include "public/platform/WebRTCCertificate.h"
 #include "public/platform/WebRTCCertificateGenerator.h"
 #include "public/platform/WebRTCConfiguration.h"
 #include "public/platform/WebRTCDataChannelHandler.h"
 #include "public/platform/WebRTCDataChannelInit.h"
+#include "public/platform/WebRTCError.h"
 #include "public/platform/WebRTCICECandidate.h"
 #include "public/platform/WebRTCKeyParams.h"
 #include "public/platform/WebRTCOfferOptions.h"
 #include "public/platform/WebRTCSessionDescription.h"
 #include "public/platform/WebRTCSessionDescriptionRequest.h"
 #include "public/platform/WebRTCStatsRequest.h"
 #include "public/platform/WebRTCVoidRequest.h"
 #include "wtf/CurrentTime.h"
 #include "wtf/PtrUtil.h"
 #include <algorithm>
@@ skipping 683 matching lines @@
 
 RTCSessionDescription* RTCPeerConnection::remoteDescription() {
   WebRTCSessionDescription webSessionDescription =
       m_peerHandler->remoteDescription();
   if (webSessionDescription.isNull())
     return nullptr;
 
   return RTCSessionDescription::create(webSessionDescription);
 }
 
-void RTCPeerConnection::updateIce(ExecutionContext* context,
-                                  const RTCConfiguration& rtcConfiguration,
-                                  const Dictionary&,
-                                  ExceptionState& exceptionState) {
+void RTCPeerConnection::setConfiguration(
+    ExecutionContext* context,
+    const RTCConfiguration& rtcConfiguration,
+    ExceptionState& exceptionState) {
   if (throwExceptionIfSignalingStateClosed(m_signalingState, exceptionState))
     return;
 
   WebRTCConfiguration configuration =
       parseConfiguration(context, rtcConfiguration, exceptionState);
 
   if (exceptionState.hadException())
     return;
 
   MediaErrorState mediaErrorState;
   if (mediaErrorState.hadException()) {
     mediaErrorState.raiseException(exceptionState);
     return;
   }
 
-  // TODO(deadbeef): When this changes to setConfiguration, call
-  // m_peerHandler->setConfiguration.
-  exceptionState.throwDOMException(
-      SyntaxError,
-      "Could not update the ICE Agent with the given configuration.");
+  WebRTCErrorType error = m_peerHandler->setConfiguration(configuration);
+  if (error != WebRTCErrorType::kNone) {
+    // All errors besides InvalidModification should have been detected above.
+    if (error == WebRTCErrorType::kInvalidModification) {
+      exceptionState.throwDOMException(
+          InvalidModificationError,
+          "Attempted to modify the PeerConnection's "
+          "configuration in an unsupported way.");
+    } else {
+      exceptionState.throwDOMException(
+          OperationError,
+          "Could not update the PeerConnection with the given configuration.");
+    }
+  }
 }
 
 ScriptPromise RTCPeerConnection::generateCertificate(
     ScriptState* scriptState,
     const AlgorithmIdentifier& keygenAlgorithm,
     ExceptionState& exceptionState) {
   // Normalize |keygenAlgorithm| with WebCrypto, making sure it is a recognized
   // AlgorithmIdentifier.
   WebCryptoAlgorithm cryptoAlgorithm;
   AlgorithmError error;
@@ skipping 646 matching lines @@
 DEFINE_TRACE(RTCPeerConnection) {
   visitor->trace(m_localStreams);
   visitor->trace(m_remoteStreams);
   visitor->trace(m_dispatchScheduledEventRunner);
   visitor->trace(m_scheduledEvents);
   EventTargetWithInlineData::trace(visitor);
   SuspendableObject::trace(visitor);
 }
 
 }  // namespace blink