Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(837)

Unified Diff: third_party/WebKit/Source/modules/webdatabase/SQLStatementBackend.cpp

Issue 2631403002: Fix SQLStatementBackend::m_resultSet to use CrossThreadPersistent
Patch Set: fix Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/modules/webdatabase/SQLStatementBackend.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/modules/webdatabase/SQLStatementBackend.cpp
diff --git a/third_party/WebKit/Source/modules/webdatabase/SQLStatementBackend.cpp b/third_party/WebKit/Source/modules/webdatabase/SQLStatementBackend.cpp
index d67754efb88ab67cf03fc758c4441f94e0917765..cdba5c33a976eff3225e3cabf7692f5390ede58f 100644
--- a/third_party/WebKit/Source/modules/webdatabase/SQLStatementBackend.cpp
+++ b/third_party/WebKit/Source/modules/webdatabase/SQLStatementBackend.cpp
@@ -108,7 +108,6 @@ SQLStatementBackend::SQLStatementBackend(SQLStatement* frontend,
DEFINE_TRACE(SQLStatementBackend) {
visitor->trace(m_frontend);
- visitor->trace(m_resultSet);
}
SQLStatement* SQLStatementBackend::frontend() {
@@ -193,7 +192,7 @@ bool SQLStatementBackend::execute(Database* db) {
result = statement.step();
if (result == SQLResultRow) {
int columnCount = statement.columnCount();
- SQLResultSetRowList* rows = m_resultSet->rows();
+ CrossThreadPersistent<SQLResultSetRowList> rows = m_resultSet->rows();
sof 2017/01/17 14:13:03 This too I'm also not understanding -- if a thread
for (int i = 0; i < columnCount; i++)
rows->addColumn(statement.getColumnName(i));
« no previous file with comments | « third_party/WebKit/Source/modules/webdatabase/SQLStatementBackend.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698