Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(735)

Unified Diff: ui/views/animation/flood_fill_ink_drop_ripple.cc

Issue 2631333002: [animations] Adds metrics for jank on selected layer animations (Closed)
Patch Set: Adds UMA reporting for ripples and overview mode (extern constexpr) Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/views/animation/flood_fill_ink_drop_ripple.cc
diff --git a/ui/views/animation/flood_fill_ink_drop_ripple.cc b/ui/views/animation/flood_fill_ink_drop_ripple.cc
index e542679e98ed3ccb0b681adeef99315ab9a2e254..9888c07d771c2cc9e05400fadfd6ce064901831a 100644
--- a/ui/views/animation/flood_fill_ink_drop_ripple.cc
+++ b/ui/views/animation/flood_fill_ink_drop_ripple.cc
@@ -6,8 +6,10 @@
#include <algorithm>
+#include "base/lazy_instance.h"
#include "base/logging.h"
#include "third_party/skia/include/core/SkColor.h"
+#include "ui/compositor/animation_metrics_reporter_template.h"
#include "ui/compositor/layer.h"
#include "ui/compositor/layer_animation_sequence.h"
#include "ui/compositor/scoped_layer_animation_settings.h"
@@ -113,6 +115,11 @@ float CalculateCircleLayerRadius(const gfx::Rect& clip_bounds) {
return std::max(clip_bounds.width(), clip_bounds.height()) / 2.f;
}
+extern constexpr char kMetricName[] =
+ "Views.AnimationSmoothness.FloodFillRipple";
+base::LazyInstance<ui::AnimationMetricsReporterTemplate<kMetricName>>::Leaky
+ g_reporter = LAZY_INSTANCE_INITIALIZER;
+
} // namespace
namespace views {
@@ -327,6 +334,7 @@ void FloodFillInkDropRipple::AnimateToTransform(
if (animation_observer)
sequence->AddObserver(animation_observer);
+ sequence->SetAnimationMetricsReporter(g_reporter.Pointer());
animator->StartAnimation(sequence);
}
@@ -348,6 +356,7 @@ void FloodFillInkDropRipple::PauseTransformAnimation(
if (observer)
sequence->AddObserver(observer);
+ sequence->SetAnimationMetricsReporter(g_reporter.Pointer());
animator->StartAnimation(sequence);
}
@@ -373,6 +382,7 @@ void FloodFillInkDropRipple::AnimateToOpacity(
if (animation_observer)
animation_sequence->AddObserver(animation_observer);
+ animation_sequence->SetAnimationMetricsReporter(g_reporter.Pointer());
animator->StartAnimation(animation_sequence);
}
@@ -394,6 +404,7 @@ void FloodFillInkDropRipple::PauseOpacityAnimation(
if (observer)
sequence->AddObserver(observer);
+ sequence->SetAnimationMetricsReporter(g_reporter.Pointer());
animator->StartAnimation(sequence);
}

Powered by Google App Engine
This is Rietveld 408576698