Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Side by Side Diff: third_party/WebKit/Source/devtools/front_end/sdk/NetworkManager.js

Issue 2631313003: [Devtools] Bug fix with url as undefined in blocked requests (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2011 Google Inc. All rights reserved. 2 * Copyright (C) 2011 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 426 matching lines...) Expand 10 before | Expand all | Expand 10 after
437 437
438 networkRequest.failed = true; 438 networkRequest.failed = true;
439 networkRequest.setResourceType(Common.resourceTypes[resourceType]); 439 networkRequest.setResourceType(Common.resourceTypes[resourceType]);
440 networkRequest.canceled = !!canceled; 440 networkRequest.canceled = !!canceled;
441 if (blockedReason) { 441 if (blockedReason) {
442 networkRequest.setBlockedReason(blockedReason); 442 networkRequest.setBlockedReason(blockedReason);
443 if (blockedReason === Protocol.Network.BlockedReason.Inspector) { 443 if (blockedReason === Protocol.Network.BlockedReason.Inspector) {
444 var consoleModel = this._manager._target.consoleModel; 444 var consoleModel = this._manager._target.consoleModel;
445 consoleModel.addMessage(new SDK.ConsoleMessage( 445 consoleModel.addMessage(new SDK.ConsoleMessage(
446 consoleModel.target(), SDK.ConsoleMessage.MessageSource.Network, SDK .ConsoleMessage.MessageLevel.Warning, 446 consoleModel.target(), SDK.ConsoleMessage.MessageSource.Network, SDK .ConsoleMessage.MessageLevel.Warning,
447 Common.UIString('Request was blocked by DevTools: "%s".', networkReq uest.url), 447 Common.UIString('Request was blocked by DevTools: "%s".', networkReq uest.url()),
448 SDK.ConsoleMessage.MessageType.Log, '', 0, 0, networkRequest.request Id())); 448 SDK.ConsoleMessage.MessageType.Log, '', 0, 0, networkRequest.request Id()));
449 } 449 }
450 } 450 }
451 networkRequest.localizedFailDescription = localizedDescription; 451 networkRequest.localizedFailDescription = localizedDescription;
452 this._finishNetworkRequest(networkRequest, time, -1); 452 this._finishNetworkRequest(networkRequest, time, -1);
453 } 453 }
454 454
455 /** 455 /**
456 * @override 456 * @override
457 * @param {!Protocol.Network.RequestId} requestId 457 * @param {!Protocol.Network.RequestId} requestId
(...skipping 439 matching lines...) Expand 10 before | Expand all | Expand 10 after
897 SDK.MultitargetNetworkManager.Events = { 897 SDK.MultitargetNetworkManager.Events = {
898 ConditionsChanged: Symbol('ConditionsChanged'), 898 ConditionsChanged: Symbol('ConditionsChanged'),
899 UserAgentChanged: Symbol('UserAgentChanged') 899 UserAgentChanged: Symbol('UserAgentChanged')
900 }; 900 };
901 901
902 902
903 /** 903 /**
904 * @type {!SDK.MultitargetNetworkManager} 904 * @type {!SDK.MultitargetNetworkManager}
905 */ 905 */
906 SDK.multitargetNetworkManager; 906 SDK.multitargetNetworkManager;
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698