third_party/WebKit/Source/web/tests/FrameTestHelpers.h - Issue 2631233003: Avoid mutating frame owner when detaching a provisional frame.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/tests/FrameTestHelpers.h

Issue 2631233003: Avoid mutating frame owner when detaching a provisional frame. (Closed)

Patch Set: Fix test to actually test the changed behavior. Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/web/tests/FrameTestHelpers.h

diff --git a/third_party/WebKit/Source/web/tests/FrameTestHelpers.h b/third_party/WebKit/Source/web/tests/FrameTestHelpers.h

index 35e217cbac6d445028bba19ee69e6c9f077e5ded..67c41b3da3aece9738a600237fa6772de9555f75 100644

--- a/third_party/WebKit/Source/web/tests/FrameTestHelpers.h

+++ b/third_party/WebKit/Source/web/tests/FrameTestHelpers.h

@@ -237,6 +237,7 @@ class TestWebFrameClient : public WebFrameClient {

public:

TestWebFrameClient();

+ void frameDetached(WebLocalFrame*, DetachType) override;

WebLocalFrame* createChildFrame(WebLocalFrame* parent,

WebTreeScopeType,

const WebString& name,