Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Side by Side Diff: third_party/WebKit/Source/core/paint/PaintLayer.cpp

Issue 2631193002: Make having an existing ancestor overflow layer when adding a PaintLayer fatal. (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2006, 2007, 2008, 2009, 2010, 2011, 2012 Apple Inc. All rights 2 * Copyright (C) 2006, 2007, 2008, 2009, 2010, 2011, 2012 Apple Inc. All rights
3 * reserved. 3 * reserved.
4 * 4 *
5 * Portions are Copyright (C) 1998 Netscape Communications Corporation. 5 * Portions are Copyright (C) 1998 Netscape Communications Corporation.
6 * 6 *
7 * Other contributors: 7 * Other contributors:
8 * Robert O'Callahan <roc+@cs.cmu.edu> 8 * Robert O'Callahan <roc+@cs.cmu.edu>
9 * David Baron <dbaron@fas.harvard.edu> 9 * David Baron <dbaron@fas.harvard.edu>
10 * Christian Biesinger <cbiesinger@web.de> 10 * Christian Biesinger <cbiesinger@web.de>
(...skipping 1211 matching lines...) Expand 10 before | Expand all | Expand 10 after
1222 child->setNextSibling(beforeChild); 1222 child->setNextSibling(beforeChild);
1223 DCHECK(beforeChild != child); 1223 DCHECK(beforeChild != child);
1224 } else { 1224 } else {
1225 setLastChild(child); 1225 setLastChild(child);
1226 } 1226 }
1227 1227
1228 child->m_parent = this; 1228 child->m_parent = this;
1229 1229
1230 // The ancestor overflow layer is calculated during compositing inputs update 1230 // The ancestor overflow layer is calculated during compositing inputs update
1231 // and should not be set yet. 1231 // and should not be set yet.
1232 DCHECK(!child->ancestorOverflowLayer()); 1232 CHECK(!child->ancestorOverflowLayer());
1233 1233
1234 setNeedsCompositingInputsUpdate(); 1234 setNeedsCompositingInputsUpdate();
1235 1235
1236 if (!child->stackingNode()->isStacked() && 1236 if (!child->stackingNode()->isStacked() &&
1237 !layoutObject()->documentBeingDestroyed()) 1237 !layoutObject()->documentBeingDestroyed())
1238 compositor()->setNeedsCompositingUpdate(CompositingUpdateRebuildTree); 1238 compositor()->setNeedsCompositingUpdate(CompositingUpdateRebuildTree);
1239 1239
1240 if (child->stackingNode()->isStacked() || child->firstChild()) { 1240 if (child->stackingNode()->isStacked() || child->firstChild()) {
1241 // Dirty the z-order list in which we are contained. The 1241 // Dirty the z-order list in which we are contained. The
1242 // ancestorStackingContextNode() can be null in the case where we're 1242 // ancestorStackingContextNode() can be null in the case where we're
(...skipping 1978 matching lines...) Expand 10 before | Expand all | Expand 10 after
3221 } 3221 }
3222 3222
3223 void showLayerTree(const blink::LayoutObject* layoutObject) { 3223 void showLayerTree(const blink::LayoutObject* layoutObject) {
3224 if (!layoutObject) { 3224 if (!layoutObject) {
3225 LOG(INFO) << "Cannot showLayerTree. Root is (nil)"; 3225 LOG(INFO) << "Cannot showLayerTree. Root is (nil)";
3226 return; 3226 return;
3227 } 3227 }
3228 showLayerTree(layoutObject->enclosingLayer()); 3228 showLayerTree(layoutObject->enclosingLayer());
3229 } 3229 }
3230 #endif 3230 #endif
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698