Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(398)

Side by Side Diff: third_party/WebKit/Source/core/frame/FrameView.h

Issue 2631113003: Add metric to know how user use scrollbar (Closed)
Patch Set: bokan comments addressed Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/frame/FrameView.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 Copyright (C) 1997 Martin Jones (mjones@kde.org) 2 Copyright (C) 1997 Martin Jones (mjones@kde.org)
3 (C) 1998 Waldo Bastian (bastian@kde.org) 3 (C) 1998 Waldo Bastian (bastian@kde.org)
4 (C) 1998, 1999 Torben Weis (weis@kde.org) 4 (C) 1998, 1999 Torben Weis (weis@kde.org)
5 (C) 1999 Lars Knoll (knoll@kde.org) 5 (C) 1999 Lars Knoll (knoll@kde.org)
6 (C) 1999 Antti Koivisto (koivisto@kde.org) 6 (C) 1999 Antti Koivisto (koivisto@kde.org)
7 Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009 Apple Inc. All rights 7 Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009 Apple Inc. All rights
8 reserved. 8 reserved.
9 9
10 This library is free software; you can redistribute it and/or 10 This library is free software; you can redistribute it and/or
(...skipping 37 matching lines...) Expand 10 before | Expand all | Expand 10 after
48 #include "platform/scroll/Scrollbar.h" 48 #include "platform/scroll/Scrollbar.h"
49 #include "public/platform/ShapeProperties.h" 49 #include "public/platform/ShapeProperties.h"
50 #include "public/platform/WebDisplayMode.h" 50 #include "public/platform/WebDisplayMode.h"
51 #include "public/platform/WebRect.h" 51 #include "public/platform/WebRect.h"
52 #include "wtf/Allocator.h" 52 #include "wtf/Allocator.h"
53 #include "wtf/AutoReset.h" 53 #include "wtf/AutoReset.h"
54 #include "wtf/Forward.h" 54 #include "wtf/Forward.h"
55 #include "wtf/HashSet.h" 55 #include "wtf/HashSet.h"
56 #include "wtf/ListHashSet.h" 56 #include "wtf/ListHashSet.h"
57 #include "wtf/text/WTFString.h" 57 #include "wtf/text/WTFString.h"
58
59 #include <bitset>
58 #include <memory> 60 #include <memory>
59 61
60 namespace blink { 62 namespace blink {
61 63
62 class AXObjectCache; 64 class AXObjectCache;
63 class ComputedStyle; 65 class ComputedStyle;
64 class DocumentLifecycle; 66 class DocumentLifecycle;
65 class Cursor; 67 class Cursor;
66 class Element; 68 class Element;
67 class ElementVisibilityObserver; 69 class ElementVisibilityObserver;
(...skipping 443 matching lines...) Expand 10 before | Expand all | Expand 10 after
511 513
512 void setScrollingModesLock(bool lock = true) { 514 void setScrollingModesLock(bool lock = true) {
513 m_horizontalScrollbarLock = m_verticalScrollbarLock = lock; 515 m_horizontalScrollbarLock = m_verticalScrollbarLock = lock;
514 } 516 }
515 517
516 bool canHaveScrollbars() const { 518 bool canHaveScrollbars() const {
517 return horizontalScrollbarMode() != ScrollbarAlwaysOff || 519 return horizontalScrollbarMode() != ScrollbarAlwaysOff ||
518 verticalScrollbarMode() != ScrollbarAlwaysOff; 520 verticalScrollbarMode() != ScrollbarAlwaysOff;
519 } 521 }
520 522
523 bool shouldSendScrollbarUseUMA(int part) override;
524
521 // The visible content rect has a location that is the scrolled offset of 525 // The visible content rect has a location that is the scrolled offset of
522 // the document. The width and height are the layout viewport width and 526 // the document. The width and height are the layout viewport width and
523 // height. By default the scrollbars themselves are excluded from this 527 // height. By default the scrollbars themselves are excluded from this
524 // rectangle, but an optional boolean argument allows them to be included. 528 // rectangle, but an optional boolean argument allows them to be included.
525 IntRect visibleContentRect( 529 IntRect visibleContentRect(
526 IncludeScrollbarsInRect = ExcludeScrollbars) const override; 530 IncludeScrollbarsInRect = ExcludeScrollbars) const override;
527 IntSize visibleContentSize(IncludeScrollbarsInRect = ExcludeScrollbars) const; 531 IntSize visibleContentSize(IncludeScrollbarsInRect = ExcludeScrollbars) const;
528 532
529 // Clips the provided rect to the visible content area. For this purpose, we 533 // Clips the provided rect to the visible content area. For this purpose, we
530 // also query the chrome client for any active overrides to the visible area 534 // also query the chrome client for any active overrides to the visible area
(...skipping 564 matching lines...) Expand 10 before | Expand all | Expand 10 after
1095 // Verified when finalizing. 1099 // Verified when finalizing.
1096 bool m_hasBeenDisposed; 1100 bool m_hasBeenDisposed;
1097 #endif 1101 #endif
1098 1102
1099 ScrollbarMode m_horizontalScrollbarMode; 1103 ScrollbarMode m_horizontalScrollbarMode;
1100 ScrollbarMode m_verticalScrollbarMode; 1104 ScrollbarMode m_verticalScrollbarMode;
1101 1105
1102 bool m_horizontalScrollbarLock; 1106 bool m_horizontalScrollbarLock;
1103 bool m_verticalScrollbarLock; 1107 bool m_verticalScrollbarLock;
1104 1108
1109 std::bitset<ScrollbarUseUMAMax> m_sentScrollbarUseUMA;
bokan 2017/01/17 17:04:05 A page will have multiple FrameViews. Put this on
1110
1105 ChildrenWidgetSet m_children; 1111 ChildrenWidgetSet m_children;
1106 1112
1107 ScrollOffset m_pendingScrollDelta; 1113 ScrollOffset m_pendingScrollDelta;
1108 ScrollOffset m_scrollOffset; 1114 ScrollOffset m_scrollOffset;
1109 IntSize m_contentsSize; 1115 IntSize m_contentsSize;
1110 1116
1111 bool m_scrollbarsSuppressed; 1117 bool m_scrollbarsSuppressed;
1112 1118
1113 bool m_inUpdateScrollbars; 1119 bool m_inUpdateScrollbars;
1114 1120
(...skipping 108 matching lines...) Expand 10 before | Expand all | Expand 10 after
1223 widget.isFrameView()); 1229 widget.isFrameView());
1224 DEFINE_TYPE_CASTS(FrameView, 1230 DEFINE_TYPE_CASTS(FrameView,
1225 ScrollableArea, 1231 ScrollableArea,
1226 scrollableArea, 1232 scrollableArea,
1227 scrollableArea->isFrameView(), 1233 scrollableArea->isFrameView(),
1228 scrollableArea.isFrameView()); 1234 scrollableArea.isFrameView());
1229 1235
1230 } // namespace blink 1236 } // namespace blink
1231 1237
1232 #endif // FrameView_h 1238 #endif // FrameView_h
OLDNEW
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/frame/FrameView.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698