Issue 263103006: Set max new space size in tests to proper MB value.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 263103006: Set max new space size in tests to proper MB value. (Closed)

Created:
6 years, 7 months ago by Hannes Payer (out of office)

Modified:
6 years, 7 months ago

Reviewers:
Jakob Kummerow

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Set max new space size in tests to proper MB value. Revert "Limit old space size in test which require a large new space." This reverts commit r21103. Revert "Remove max space limits in tests." This reverts commit r21104. BUG= R=jkummerow@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=21149

Patch Set 1 #

Patch Set 2 : #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+24 lines, -22 lines)			Patch
M	test/cctest/test-api.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	test/cctest/test-heap.cc	View		10 chunks	+10 lines, -10 lines	0 comments	Download
M	test/cctest/test-strings.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	test/mjsunit/binary-op-newspace.js	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	test/mjsunit/compiler/math-floor-global.js	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	test/mjsunit/compiler/math-floor-local.js	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	test/mjsunit/define-property-gc.js	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	test/mjsunit/math-abs.js	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	test/mjsunit/math-floor-part1.js	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	test/mjsunit/math-floor-part2.js	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	test/mjsunit/math-floor-part3.js	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	test/mjsunit/math-floor-part4.js	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	test/mjsunit/regress/regress-1708.js	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	test/mjsunit/regress/regress-99167.js	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	test/mjsunit/regress/regress-create-exception.js	View	1	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Jakob Kummerow

In the mjsunit tests you'll have to convert the sizes to MB. Also, please use ...

6 years, 7 months ago (2014-05-05 16:41:32 UTC) #2

Hannes Payer (out of office)

6 years, 7 months ago (2014-05-05 16:48:53 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r21149 (presubmit successful).

Expand Messages | Collapse Messages