Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1266)

Unified Diff: tests/compiler/dart2js/mirror_helper_test.dart

Issue 263103003: Remove warnings from dart2js test-suite. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Remove debug code. Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tests/compiler/dart2js/mirror_helper_test.dart
diff --git a/tests/compiler/dart2js/mirror_helper_test.dart b/tests/compiler/dart2js/mirror_helper_test.dart
index 57c869bec6b8d894680b54cf2efb4bcb3bfd7509..1f3b7aea827080c5286bf03c593af178d15f44f1 100644
--- a/tests/compiler/dart2js/mirror_helper_test.dart
+++ b/tests/compiler/dart2js/mirror_helper_test.dart
@@ -15,7 +15,7 @@ show
import
'../../../sdk/lib/_internal/compiler/implementation/tree/tree.dart'
show
- Node;
+ Block, ExpressionStatement, FunctionExpression, Node, Send;
import
'../../../sdk/lib/_internal/compiler/implementation/dart_backend/dart_backend.dart'
show
@@ -54,13 +54,15 @@ void testWithMirrorRenaming({bool minify}) {
Map<Node, String> renames = backend.renames;
Map<LibraryElement, String> imports = backend.imports;
- Node getNameFunctionNode =
- backend.memberNodes.values.first.first.body.statements.nodes.head;
+ FunctionExpression node = backend.memberNodes.values.first.first;
+ Block block = node.body;
+ ExpressionStatement getNameFunctionNode = block.statements.nodes.head;
+ Send send = getNameFunctionNode.expression;
Expect.equals(renames[mirrorRenamer.mirrorHelperGetNameFunctionNode.name],
- renames[getNameFunctionNode.expression.selector]);
+ renames[send.selector]);
Expect.equals("",
- renames[getNameFunctionNode.expression.receiver]);
+ renames[send.receiver]);
Expect.equals(1, imports.keys.length);
}));
}
@@ -73,11 +75,13 @@ void testWithoutMirrorRenaming({bool minify}) {
Map<Node, String> renames = backend.renames;
Map<LibraryElement, String> imports = backend.imports;
- Node getNameFunctionNode =
- backend.memberNodes.values.first.first.body.statements.nodes.head;
+ FunctionExpression node = backend.memberNodes.values.first.first;
+ Block block = node.body;
+ ExpressionStatement getNameFunctionNode = block.statements.nodes.head;
+ Send send = getNameFunctionNode.expression;
- Expect.isFalse(renames.containsKey(getNameFunctionNode.expression.selector));
- Expect.isFalse(renames.containsKey(getNameFunctionNode.expression.receiver));
+ Expect.isFalse(renames.containsKey(send.selector));
+ Expect.isFalse(renames.containsKey(send.receiver));
Expect.equals(1, imports.keys.length);
}));
}
« no previous file with comments | « tests/compiler/dart2js/metadata_test.dart ('k') | tests/compiler/dart2js/mirror_helper_unique_minification_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698