Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1520)

Unified Diff: tests/compiler/dart2js/bad_output_io_test.dart

Issue 263103003: Remove warnings from dart2js test-suite. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Remove debug code. Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sdk/lib/mirrors/mirrors.dart ('k') | tests/compiler/dart2js/begin_end_token_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/compiler/dart2js/bad_output_io_test.dart
diff --git a/tests/compiler/dart2js/bad_output_io_test.dart b/tests/compiler/dart2js/bad_output_io_test.dart
index f8ec58b67c19e37b8270ef10ad2516d07595e606..ebc3a6de97e6e1b4491ba8afa190a2103ce3e00b 100644
--- a/tests/compiler/dart2js/bad_output_io_test.dart
+++ b/tests/compiler/dart2js/bad_output_io_test.dart
@@ -8,7 +8,6 @@ library dart2js.test.missing_file;
import 'dart:io' show exit;
import 'package:expect/expect.dart';
-import "package:async_helper/async_helper.dart";
import '../../../sdk/lib/_internal/compiler/compiler.dart'
show Diagnostic;
@@ -45,6 +44,10 @@ class CollectingFormattingDiagnosticHandler
void call(Uri uri, int begin, int end, String message, kind) {
diagnosticHandler(uri, begin, end, message, kind);
}
+
+ String prefixMessage(String message, Diagnostic kind) {
+ return message;
+ }
}
testOutputProvider(script, libraryRoot, packageRoot, inputProvider, handler,
@@ -56,8 +59,9 @@ testOutputProvider(script, libraryRoot, packageRoot, inputProvider, handler,
void main() {
compileFunc = testOutputProvider;
exitFunc = (exitCode) {
- Expect.equals(1, diagnosticHandler.messages.length);
- var message = diagnosticHandler.messages[0];
+ CollectingFormattingDiagnosticHandler handler = diagnosticHandler;
+ Expect.equals(1, handler.messages.length);
+ var message = handler.messages[0];
Expect.isTrue(message[0].contains("Cannot open file"));
Expect.equals(Diagnostic.ERROR, message[1]);
Expect.equals(1, exitCode);
« no previous file with comments | « sdk/lib/mirrors/mirrors.dart ('k') | tests/compiler/dart2js/begin_end_token_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698