runtime/vm/assembler.cc - Issue 263093005: - When requested, always generate code comments. Disassembly

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/assembler.cc

Issue 263093005: - When requested, always generate code comments. Disassembly (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/assembler.cc

===================================================================

--- runtime/vm/assembler.cc (revision 35767)

+++ runtime/vm/assembler.cc (working copy)

@@ -13,7 +13,7 @@

namespace dart {

-DEFINE_FLAG(bool, code_comments, true,

+DEFINE_FLAG(bool, code_comments, false,

"Include comments into code and disassembly");

#if defined(TARGET_ARCH_ARM) || defined(TARGET_ARCH_MIPS)

DEFINE_FLAG(bool, use_far_branches, false,

@@ -210,7 +210,7 @@

void Assembler::Comment(const char* format, ...) {

- if (FLAG_code_comments && (FLAG_disassemble || FLAG_disassemble_optimized)) {

+ if (FLAG_code_comments || FLAG_disassemble || FLAG_disassemble_optimized) {

char buffer[1024];

va_list args;

« no previous file with comments | « no previous file | runtime/vm/flow_graph_compiler.cc » ('j') | no next file with comments »