Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(174)

Issue 2630863002: Fix leaked script in cc/EmbeddedScript. (Closed)

Created:
3 years, 11 months ago by rmacnak
Modified:
3 years, 11 months ago
Reviewers:
zra
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix leaked script in cc/EmbeddedScript. Fixes #28345. R=zra@google.com Committed: https://github.com/dart-lang/sdk/commit/cf3e91fe39707b2d62f9580ac8da2ab0a8e83268

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M runtime/tests/vm/vm.status View 1 chunk +0 lines, -2 lines 0 comments Download
M runtime/vm/object_test.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
rmacnak
3 years, 11 months ago (2017-01-13 23:21:40 UTC) #2
zra
lgtm
3 years, 11 months ago (2017-01-13 23:24:05 UTC) #3
rmacnak
3 years, 11 months ago (2017-01-13 23:28:50 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
cf3e91fe39707b2d62f9580ac8da2ab0a8e83268 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698