Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(137)

Issue 263083012: Shorten gyp target names for PNaCl IRT Shim (Closed)

Created:
6 years, 7 months ago by Derek Schuff
Modified:
6 years, 7 months ago
CC:
chromium-reviews, binji+watch_chromium.org, chromium-apps-reviews_chromium.org, Sam Clegg, extensions-reviews_chromium.org
Visibility:
Public.

Description

Shorten gyp target names for PNaCl IRT Shim These names get expanded twice into the pathnames of some built files which in some cases cause them to exceed Windows' MAX_PATH limit and kill the build. This reduces those path lengths by ~20 chars. e.g. ../../../../../out/Release_x64/obj/ppapi/native_client/src/untrusted/pnacl_irt_shim/pnacl_irt_shim_aot.gen/pnacl_newlib_x86_32-nonsfi/pnacl_irt_shim_aot/irt_shim_ppapi.o.d becomes ../../../../../out/Release_x64/obj/ppapi/native_client/src/untrusted/pnacl_irt_shim/shim_aot.gen/pnacl_newlib_x86_32-nonsfi/shim_aot/irt_shim_ppapi.o.d R=binji@chromium.org, dyen@chromium.org, mseaborn@chromium.org, teravest@chromium.org BUG=https://code.google.com/p/nativeclient/issues/detail?id=3846 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=268292

Patch Set 1 #

Total comments: 2

Patch Set 2 : add comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -11 lines) Patch
M native_client_sdk/src/build_tools/build_sdk.py View 2 chunks +1 line, -2 lines 0 comments Download
M ppapi/native_client/native_client.gyp View 1 chunk +1 line, -1 line 0 comments Download
M ppapi/native_client/src/untrusted/pnacl_irt_shim/pnacl_irt_shim.gyp View 1 3 chunks +7 lines, -4 lines 0 comments Download
M ppapi/native_client/src/untrusted/pnacl_support_extension/pnacl_support_extension.gyp View 1 chunk +1 line, -1 line 0 comments Download
M ppapi/ppapi_nacl.gyp View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Derek Schuff
6 years, 7 months ago (2014-05-05 20:49:54 UTC) #1
Mark Seaborn
LGTM, but: Please can you file a bug describing the problem, and link it in ...
6 years, 7 months ago (2014-05-05 21:02:51 UTC) #2
David Yen
lgtm
6 years, 7 months ago (2014-05-05 21:06:18 UTC) #3
Derek Schuff
updated commit message https://codereview.chromium.org/263083012/diff/1/ppapi/native_client/src/untrusted/pnacl_irt_shim/pnacl_irt_shim.gyp File ppapi/native_client/src/untrusted/pnacl_irt_shim/pnacl_irt_shim.gyp (right): https://codereview.chromium.org/263083012/diff/1/ppapi/native_client/src/untrusted/pnacl_irt_shim/pnacl_irt_shim.gyp#newcode12 ppapi/native_client/src/untrusted/pnacl_irt_shim/pnacl_irt_shim.gyp:12: 'target_name': 'shim_aot', On 2014/05/05 21:02:52, Mark ...
6 years, 7 months ago (2014-05-05 21:34:53 UTC) #4
Derek Schuff
+binji, teravest for OWNERS in SDK and src/ppapi
6 years, 7 months ago (2014-05-05 21:36:52 UTC) #5
teravest
lgtm
6 years, 7 months ago (2014-05-05 21:38:40 UTC) #6
binji
native_client_sdk lgtm
6 years, 7 months ago (2014-05-05 21:57:03 UTC) #7
Derek Schuff
6 years, 7 months ago (2014-05-05 22:06:28 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 manually as r268292 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698