Source/core/rendering/RenderBlock.cpp - Issue 263083009: [New Multicolumn] Make fast/multicol/overflow-content.html pass in the new implementation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/rendering/RenderBlock.cpp

Issue 263083009: [New Multicolumn] Make fast/multicol/overflow-content.html pass in the new implementation. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: rebase master Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/fast/multicol/newmulticol/compare-with-old-impl/overflow-content-expected.html ('k') | Source/core/rendering/RenderBlockFlow.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/rendering/RenderBlock.cpp

diff --git a/Source/core/rendering/RenderBlock.cpp b/Source/core/rendering/RenderBlock.cpp

index 6236af469fc215673ba017bf059b37b293c38de4..18ce61293a72fda88ba6c4fb3f5f735c1a673a54 100644

--- a/Source/core/rendering/RenderBlock.cpp

+++ b/Source/core/rendering/RenderBlock.cpp

@@ -1533,11 +1533,6 @@ bool RenderBlock::simplifiedLayout()

if (needsSimplifiedNormalFlowLayout())

simplifiedNormalFlowLayout();

- // Make sure a forced break is applied after the content if we are a flow thread in a simplified layout.

- // This ensures the size information is correctly computed for the last auto-height region receiving content.

- if (isRenderFlowThread())

- toRenderFlowThread(this)->applyBreakAfterContent(clientLogicalBottom());

// Lay out our positioned objects if our positioned child bit is set.

// Also, if an absolute position element inside a relative positioned container moves, and the absolute element has a fixed position

// child, neither the fixed element nor its container learn of the movement since posChildNeedsLayout() is only marked as far as the