Source/core/rendering/RenderFlowThread.cpp - Issue 263083009: [New Multicolumn] Make fast/multicol/overflow-content.html pass in the new implementation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/rendering/RenderFlowThread.cpp

Issue 263083009: [New Multicolumn] Make fast/multicol/overflow-content.html pass in the new implementation. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/core/rendering/RenderBlock.cpp ('K') | « Source/core/rendering/RenderFlowThread.h ('k') | Source/core/rendering/RenderMultiColumnSet.h » ('j') | Source/core/rendering/RenderMultiColumnSet.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/rendering/RenderFlowThread.cpp

diff --git a/Source/core/rendering/RenderFlowThread.cpp b/Source/core/rendering/RenderFlowThread.cpp

index 3f5c801c31eede19a77f9c6ef5d989c26bcfff8a..ab80424228f7102d40e1e84f7a229416c0dda5fb 100644

--- a/Source/core/rendering/RenderFlowThread.cpp

+++ b/Source/core/rendering/RenderFlowThread.cpp

@@ -365,13 +365,6 @@ void RenderFlowThread::getRegionRangeForBox(const RenderBox* box, RenderRegion*&

ASSERT(m_regionList.contains(startRegion) && m_regionList.contains(endRegion));

}

-void RenderFlowThread::applyBreakAfterContent(LayoutUnit clientHeight)

- // Simulate a region break at height. If it points inside an auto logical height region,

- // then it may determine the region computed autoheight.

- addForcedRegionBreak(clientHeight, this, false);

void RenderFlowThread::updateRegionsFlowThreadPortionRect()

{

LayoutUnit logicalHeight = 0;