[New Multicolumn] Make fast/multicol/overflow-content.html pass in the new implementation.

[New Multicolumn] Make fast/multicol/overflow-content.html pass in the new implementation.

Insert a break at end of content on our own in the multicol code, to make sure
that overflow is properly accounted for.

BUG=369954
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=173531

[Julien - ping for review, 2014-05-07 00:55:17]

https://codereview.chromium.org/263083009/diff/1/Source/core/rendering/Render...
File Source/core/rendering/RenderMultiColumnSet.cpp (right):

https://codereview.chromium.org/263083009/diff/1/Source/core/rendering/Render...
Source/core/rendering/RenderMultiColumnSet.cpp:129:
addForcedBreak(logicalBottomInFlowThread());
Doesn't this make the call to applyBreakAfterContent in
RenderBlockFlow::layoutBlockFlow useless as we have already created a forced
break at the end of our content?

More generally, do we need applyBreakAfterContent or shouldn't we just do call
recalculateColumnHeight to make sure our content gets rebalanced appropriately?

[Julien - ping for review, 2014-05-07 01:01:10]

lgtm, I would rather fix simplified layout in this change if that's an issue.

https://codereview.chromium.org/263083009/diff/1/Source/core/rendering/Render...
File Source/core/rendering/RenderBlock.cpp (left):

https://codereview.chromium.org/263083009/diff/1/Source/core/rendering/Render...
Source/core/rendering/RenderBlock.cpp:1536:
toRenderFlowThread(this)->applyBreakAfterContent(clientLogicalBottom());
Shouldn't we call recalculateColumnHeight as our height could have changed (due
to children changing size)?

https://codereview.chromium.org/263083009/diff/1/Source/core/rendering/Render...
File Source/core/rendering/RenderMultiColumnSet.cpp (right):

https://codereview.chromium.org/263083009/diff/1/Source/core/rendering/Render...
Source/core/rendering/RenderMultiColumnSet.cpp:129:
addForcedBreak(logicalBottomInFlowThread());
On 2014/05/07 00:55:17, Julien Chaffraix - PST wrote:
> Doesn't this make the call to applyBreakAfterContent in
> RenderBlockFlow::layoutBlockFlow useless as we have already created a forced
> break at the end of our content?
> 
> More generally, do we need applyBreakAfterContent or shouldn't we just do call
> recalculateColumnHeight to make sure our content gets rebalanced
appropriately?

Forget this comment, I missed that this change had more than one file when
reviewing :-)

[mstensho (USE GERRIT), 2014-05-07 05:37:47]

On 2014/05/07 01:01:10, Julien Chaffraix - PST wrote:
> lgtm, I would rather fix simplified layout in this change if that's an issue.

It does indeed look like simplifiedLayout() lacks something here, but this CL
doesn't make it any better or worse. So I'm wondering if I should rather
investigate and file another CL, if I find that simplifiedLayout() needs to be
fixed?

[mstensho (USE GERRIT), 2014-05-07 13:25:50]

Yes, there are problems with simplifiedLayout() and multicol [1], but it's not
related to this CL, so I'll commit it now.

[1] I've filed https://code.google.com/p/chromium/issues/detail?id=370874

[mstensho (USE GERRIT), 2014-05-07 13:25:58]

The CQ bit was checked by mstensho@opera.com

[commit-bot: I haz the power, 2014-05-07 13:27:09]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/mstensho@opera.com/263083009/20001

[commit-bot: I haz the power, 2014-05-07 14:34:31]

Change committed as 173531