Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 263083008: Pass in the map while creating JSFunction, and set prototype in the client. (Closed)

Created:
6 years, 7 months ago by Toon Verwaest
Modified:
6 years, 7 months ago
Reviewers:
Igor Sheludko
CC:
v8-dev
Visibility:
Public.

Description

Pass in the map while creating JSFunction, and set prototype in the client. BUG= R=ishell@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=21166

Patch Set 1 #

Total comments: 3

Patch Set 2 : Addressed comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+141 lines, -152 lines) Patch
M src/factory.h View 1 chunk +3 lines, -4 lines 0 comments Download
M src/factory.cc View 1 6 chunks +138 lines, -148 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Toon Verwaest
PTAL
6 years, 7 months ago (2014-05-05 09:30:03 UTC) #1
Igor Sheludko
lgtm with comments: https://codereview.chromium.org/263083008/diff/1/src/factory.cc File src/factory.cc (right): https://codereview.chromium.org/263083008/diff/1/src/factory.cc#newcode1210 src/factory.cc:1210: Handle<Context> context(isolate()->context()->native_context()); Does it make sense ...
6 years, 7 months ago (2014-05-05 16:11:34 UTC) #2
Toon Verwaest
6 years, 7 months ago (2014-05-06 11:26:43 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r21166 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698