Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(225)

Issue 263083006: Fix some references to Makefiles in gyp_skia. (Closed)

Created:
6 years, 7 months ago by tfarina
Modified:
6 years, 7 months ago
Reviewers:
epoger
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Fix some references to Makefiles in gyp_skia. BUG=None TEST=None, no functional changes. Just updating documentation. R=epoger@google.com Committed: https://code.google.com/p/skia/source/detail?r=14642

Patch Set 1 #

Total comments: 2

Patch Set 2 : makefile #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -5 lines) Patch
M gyp_skia View 1 2 chunks +3 lines, -5 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
tfarina
6 years, 7 months ago (2014-05-05 03:47:57 UTC) #1
hal.canary
Should we note that "build files" could mean Makefile files or build.ninja files or something ...
6 years, 7 months ago (2014-05-05 13:28:26 UTC) #2
tfarina
On 2014/05/05 13:28:26, Hal Canary wrote: > Should we note that "build files" could mean ...
6 years, 7 months ago (2014-05-05 15:37:52 UTC) #3
tfarina
Ping?
6 years, 7 months ago (2014-05-06 03:44:08 UTC) #4
tfarina
-Derek -Hal +Elliot Elliot, could you review this to me?
6 years, 7 months ago (2014-05-07 03:06:50 UTC) #5
epoger
Just one change to request... https://codereview.chromium.org/263083006/diff/1/gyp_skia File gyp_skia (right): https://codereview.chromium.org/263083006/diff/1/gyp_skia#newcode38 gyp_skia:38: # build files regeneration ...
6 years, 7 months ago (2014-05-07 13:47:01 UTC) #6
tfarina
Thanks Elliot! ptal. https://codereview.chromium.org/263083006/diff/1/gyp_skia File gyp_skia (right): https://codereview.chromium.org/263083006/diff/1/gyp_skia#newcode38 gyp_skia:38: # build files regeneration which only ...
6 years, 7 months ago (2014-05-07 14:41:10 UTC) #7
epoger
lgtm
6 years, 7 months ago (2014-05-07 15:02:25 UTC) #8
tfarina
6 years, 7 months ago (2014-05-08 15:14:33 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 manually as r14642 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698