Remove "Alternate frame caption button style" command line flag

Remove the "Alternate frame caption button style" command line flag. The flag has on by default in M-35 and there is no plan to turn it off.

BUG=None
TEST=None
R=flackr
TBR=oshima (for trivial deletions in ash/resources and ash/metrics)

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=268525

[pkotwicz, 2014-05-05 02:23:42]

flackr@ PTAL

[flackr, 2014-05-06 00:08:31]

Hurray, obsolete code removal! LGTM with a few nits.

https://codereview.chromium.org/263083005/diff/40001/ash/frame/caption_button...
File ash/frame/caption_buttons/bubble_contents_button_row.cc (left):

https://codereview.chromium.org/263083005/diff/40001/ash/frame/caption_button...
ash/frame/caption_buttons/bubble_contents_button_row.cc:182:
IDR_AURA_WINDOW_POSITION_LEFT_RESTORE_P);
I think these resources can be removed from ash_resources.grd (and subsequently
deleted :-) ).

https://codereview.chromium.org/263083005/diff/40001/ash/frame/caption_button...
File ash/frame/caption_buttons/frame_caption_button_container_view.cc (right):

https://codereview.chromium.org/263083005/diff/40001/ash/frame/caption_button...
ash/frame/caption_buttons/frame_caption_button_container_view.cc:57:
size_button_ = new AlternateFrameSizeButton(this, frame, this);
At some point AlternateFrameX* should probably become FrameX*.

https://codereview.chromium.org/263083005/diff/40001/ash/wm/workspace/workspa...
File ash/wm/workspace/workspace_window_resizer.cc (right):

https://codereview.chromium.org/263083005/diff/40001/ash/wm/workspace/workspa...
ash/wm/workspace/workspace_window_resizer.cc:914: DockedAlignment
desired_alignment = (snap_type_ == SNAP_LEFT) ?
Hmmm, maybe DCHECK(snap_type_ == SNAP_LEFT || snap_type_ == SNAP_RIGHT) before
this just to document this expectation and ensure it's at least true when
running debug?

[pkotwicz, 2014-05-06 01:43:17]

https://codereview.chromium.org/263083005/diff/40001/ash/frame/caption_button...
File ash/frame/caption_buttons/bubble_contents_button_row.cc (left):

https://codereview.chromium.org/263083005/diff/40001/ash/frame/caption_button...
ash/frame/caption_buttons/bubble_contents_button_row.cc:182:
IDR_AURA_WINDOW_POSITION_LEFT_RESTORE_P);
Done. Turns out that I had forgotten to remove UMA constants and strings which
are no longer used too

https://codereview.chromium.org/263083005/diff/40001/ash/wm/workspace/workspa...
File ash/wm/workspace/workspace_window_resizer.cc (right):

https://codereview.chromium.org/263083005/diff/40001/ash/wm/workspace/workspa...
ash/wm/workspace/workspace_window_resizer.cc:914: DockedAlignment
desired_alignment = (snap_type_ == SNAP_LEFT) ?
On 2014/05/06 00:08:31, flackr wrote:
> Hmmm, maybe DCHECK(snap_type_ == SNAP_LEFT || snap_type_ == SNAP_RIGHT) before
> this just to document this expectation and ensure it's at least true when
> running debug?

Done.

[pkotwicz, 2014-05-06 01:43:22]

The CQ bit was checked by pkotwicz@chromium.org

[commit-bot: I haz the power, 2014-05-06 01:43:43]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/pkotwicz@chromium.org/263083005/50001

[commit-bot: I haz the power, 2014-05-06 03:43:46]

FYI, CQ is re-trying this CL (attempt #1).
Please consider checking whether the failures are real,
and report flakes to chrome-troopers@google.com.
The failing builders are:
  android_aosp on tryserver.chromium
  android_clang_dbg on tryserver.chromium
  android_dbg on tryserver.chromium
  chromium_presubmit on tryserver.chromium
  ios_dbg_simulator on tryserver.chromium
  ios_rel_device on tryserver.chromium
  ios_rel_device_ninja on tryserver.chromium
  linux_chromium_chromeos_clang_dbg on tryserver.chromium
  linux_chromium_chromeos_rel on tryserver.chromium
  linux_chromium_clang_dbg on tryserver.chromium
  linux_chromium_gn_rel on tryserver.chromium
  linux_chromium_rel on tryserver.chromium
  mac_chromium_compile_dbg on tryserver.chromium
  mac_chromium_rel on tryserver.chromium
  win_chromium_compile_dbg on tryserver.chromium
  win_chromium_rel on tryserver.chromium
  win_chromium_x64_rel on tryserver.chromium

[pkotwicz, 2014-05-06 03:50:15]

The CQ bit was unchecked by pkotwicz@chromium.org

[pkotwicz, 2014-05-06 14:07:23]

The CQ bit was checked by pkotwicz@chromium.org

[commit-bot: I haz the power, 2014-05-06 14:07:44]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/pkotwicz@chromium.org/263083005/70001

[commit-bot: I haz the power, 2014-05-06 15:56:16]

Change committed as 268525