Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(148)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 26308002: Fix some WeakPtrFactory members that aren't last (Closed)

Created:
7 years, 2 months ago by dmichael (off chromium)
Modified:
7 years, 2 months ago
Reviewers:
Nico, yzshen1, Ryan Sleevi
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, cbentzel+watch_chromium.org, erikwright+watch_chromium.org, jam
Visibility:
Public.

Description

Fix some WeakPtrFactory members that aren't last BUG=303818 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=227566

Patch Set 1 #

Patch Set 2 : fix a RunLoop initializer I missed #

Patch Set 3 : Fix weak ptr initialization #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -38 lines) Patch
M base/run_loop.h View 2 chunks +3 lines, -3 lines 0 comments Download
M base/run_loop.cc View 1 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/renderer/pepper/pepper_flash_renderer_host.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/pepper/pepper_flash_renderer_host.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/renderer/pepper/content_decryptor_delegate.h View 1 chunk +3 lines, -3 lines 0 comments Download
M content/renderer/pepper/content_decryptor_delegate.cc View 1 2 1 chunk +3 lines, -3 lines 0 comments Download
M content/renderer/pepper/message_channel.h View 2 chunks +4 lines, -4 lines 0 comments Download
M content/renderer/pepper/message_channel.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M net/http/http_server_properties_impl.h View 1 chunk +2 lines, -2 lines 0 comments Download
M net/http/http_server_properties_impl.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M net/ssl/server_bound_cert_service.h View 2 chunks +2 lines, -1 line 0 comments Download
M net/ssl/server_bound_cert_service.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ppapi/proxy/ppb_image_data_proxy.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M ppapi/proxy/ppb_var_deprecated_proxy.h View 1 chunk +2 lines, -1 line 0 comments Download
M ppapi/proxy/ppb_var_deprecated_proxy.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ppapi/shared_impl/resource_tracker.h View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
dmichael (off chromium)
thakis: base/ rsleevi: net/ yzshen: the rest (pepper stuff)
7 years, 2 months ago (2013-10-07 18:19:25 UTC) #1
Ryan Sleevi
net/ lgtm
7 years, 2 months ago (2013-10-07 18:27:15 UTC) #2
Nico
base/ lgtm
7 years, 2 months ago (2013-10-07 18:54:56 UTC) #3
yzshen1
On 2013/10/07 18:54:56, Nico wrote: > base/ lgtm pepper LGTM. Thanks!
7 years, 2 months ago (2013-10-07 19:46:58 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dmichael@chromium.org/26308002/1
7 years, 2 months ago (2013-10-07 19:59:29 UTC) #5
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 2 months ago (2013-10-07 20:16:02 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dmichael@chromium.org/26308002/22001
7 years, 2 months ago (2013-10-07 21:18:45 UTC) #7
commit-bot: I haz the power
Retried try job too often on linux_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&number=175843
7 years, 2 months ago (2013-10-07 23:50:48 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dmichael@chromium.org/26308002/48001
7 years, 2 months ago (2013-10-08 16:26:10 UTC) #9
commit-bot: I haz the power
7 years, 2 months ago (2013-10-08 19:23:37 UTC) #10
Message was sent while issue was closed. 
Change committed as 227566

Powered by Google App Engine
This is Rietveld 408576698