Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1319)

Unified Diff: ui/views/widget/desktop_aura/desktop_window_tree_host_x11.h

Issue 2630773002: Avoid blocking while mapping an X11 window (Closed)
Patch Set: fix flaky tests Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/views/widget/desktop_aura/desktop_window_tree_host_x11.h
diff --git a/ui/views/widget/desktop_aura/desktop_window_tree_host_x11.h b/ui/views/widget/desktop_aura/desktop_window_tree_host_x11.h
index f592e1e24488f97af5100900cceced6a4667101a..949dc7855ca9cdcb534b3fb8d7fb8eddb4740e94 100644
--- a/ui/views/widget/desktop_aura/desktop_window_tree_host_x11.h
+++ b/ui/views/widget/desktop_aura/desktop_window_tree_host_x11.h
@@ -294,13 +294,11 @@ class VIEWS_EXPORT DesktopWindowTreeHostX11
ui::X11AtomCache atom_cache_;
- // Is the window mapped to the screen?
+ // Whether the window is mapped with respect to the X server.
bool window_mapped_;
- // Should we wait for an UnmapNotify before trying to remap the window?
- // If |wait_for_unmap_| is true, we have sent an XUnmapWindow request to the
- // server and have yet to receive an UnmapNotify.
- bool wait_for_unmap_;
+ // Whether the window is visible with respect to Aura.
+ bool is_visible_;
danakj 2017/03/09 20:45:34 I would name these more literally as the state the
Tom (Use chromium acct) 2017/03/10 01:29:57 Done.
// The bounds of |xwindow_|.
gfx::Rect bounds_in_pixels_;

Powered by Google App Engine
This is Rietveld 408576698