Avoid blocking while mapping an X11 window

chrome/browser/extensions/extension_commands_global_registry_apitest.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "build/build_config.h"
 #include "chrome/browser/extensions/extension_apitest.h"
 #include "chrome/browser/extensions/window_controller.h"
 #include "chrome/browser/ui/browser_window.h"
 #include "chrome/browser/ui/tabs/tab_strip_model.h"
 #include "chrome/test/base/interactive_test_utils.h"
 #include "content/public/test/browser_test_utils.h"
 #include "extensions/test/result_catcher.h"
 #include "ui/base/base_window.h"
 #include "ui/base/test/ui_controls.h"
 
 #if defined(OS_LINUX) && defined(USE_X11)
 #include <X11/Xlib.h>
 #include <X11/extensions/XTest.h>
 #include <X11/keysym.h>
-
+#include "ui/aura/window.h"
 #include "ui/events/keycodes/keyboard_code_conversion_x.h"
 #include "ui/gfx/x/x11_types.h"
+#include "ui/views/widget/desktop_aura/desktop_window_tree_host_observer_x11.h"
+#include "ui/views/widget/desktop_aura/desktop_window_tree_host_x11.h"
 #endif
 
 #if defined(OS_MACOSX)
 #include <Carbon/Carbon.h>
 
 #include "base/mac/scoped_cftyperef.h"
 #endif
 
 namespace extensions {
 
@@ skipping 115 matching lines @@
   ASSERT_TRUE(ui_test_utils::SendKeyPressSync(
       incognito_browser, ui::VKEY_1, true, true, false, false));
   ASSERT_TRUE(ui_test_utils::SendKeyPressSync(
       incognito_browser, ui::VKEY_A, true, true, false, false));
 
   // Activate the shortcut (Ctrl+Shift+8). This should have an effect.
   ASSERT_TRUE(ui_test_utils::SendKeyPressSync(
       incognito_browser, ui::VKEY_8, true, true, false, false));
 #elif defined(OS_LINUX) && defined(USE_X11)
   // Create an incognito browser to capture the focus.
-  CreateIncognitoBrowser();
+  Browser* incognito_browser = CreateIncognitoBrowser();
 
-  // On Linux, our infrastructure for sending keys just synthesize keyboard
-  // event and send them directly to the specified window, without notifying the
-  // X root window. It didn't work while testing global shortcut because the
-  // stuff of global shortcut on Linux need to be notified when KeyPress event
-  // is happening on X root window. So we simulate the keyboard input here.
-  SendNativeKeyEventToXDisplay(ui::VKEY_1, true, true, false);
-  SendNativeKeyEventToXDisplay(ui::VKEY_A, true, true, false);
-  SendNativeKeyEventToXDisplay(ui::VKEY_8, true, true, false);
+  views::DesktopWindowTreeHostX11* host =
+      static_cast<views::DesktopWindowTreeHostX11*>(
+          incognito_browser->window()->GetNativeWindow()->GetHost());
+
+  class GlobalCommandTreeHostObserver
+      : public views::DesktopWindowTreeHostObserverX11 {
+   public:
+    void OnWindowMapped(unsigned long xid) override {
+      // On Linux, our infrastructure for sending keys just synthesize keyboard
+      // event and send them directly to the specified window, without notifying
+      // the X root window. It didn't work while testing global shortcut because
+      // the stuff of global shortcut on Linux need to be notified when KeyPress
+      // event is happening on X root window. So we simulate the keyboard input
+      // here.
+      SendNativeKeyEventToXDisplay(ui::VKEY_1, true, true, false);
+      SendNativeKeyEventToXDisplay(ui::VKEY_A, true, true, false);
+      SendNativeKeyEventToXDisplay(ui::VKEY_8, true, true, false);
+    }
+
+    void OnWindowUnmapped(unsigned long xid) override {}
+  } observer;
+
+  // The observer sends the commands after window mapping
+  host->AddObserver(&observer);
+
 #elif defined(OS_MACOSX)
   // Create an incognito browser to capture the focus.
   CreateIncognitoBrowser();
 
   // Send some native mac key events.
   SendNativeCommandShift(kVK_ANSI_1);
   SendNativeCommandShift(kVK_ANSI_A);
   SendNativeCommandShift(kVK_ANSI_8);
 #endif
 
   // If this fails, it might be because the global shortcut failed to work,
   // but it might also be because the non-global shortcuts unexpectedly
   // worked.
   ASSERT_TRUE(catcher.GetNextResult()) << catcher.message();
+#if defined(OS_LINUX) && !defined(OS_CHROMEOS) && defined(USE_X11)
+  host->RemoveObserver(&observer);
+#endif
 }
 
 #if defined(OS_WIN)
 // Feature only fully implemented on Windows, other platforms coming.
 // TODO(smus): On mac, SendKeyPress must first support media keys.
 // Test occasionally times out on Windows. http://crbug.com/428813
 #define MAYBE_GlobalDuplicatedMediaKey DISABLED_GlobalDuplicatedMediaKey
 #else
 #define MAYBE_GlobalDuplicatedMediaKey DISABLED_GlobalDuplicatedMediaKey
 #endif
@@ skipping 15 matching lines @@
                             false,
                             false,
                             false);
 
   // We should get two success results.
   ASSERT_TRUE(catcher.GetNextResult());
   ASSERT_TRUE(catcher.GetNextResult());
 }
 
 }  // namespace extensions