Separate validation failures from other failures in ExecuteCodeFunction.

extensions/browser/api/execute_code_function.cc

Index: extensions/browser/api/execute_code_function.cc
diff --git a/extensions/browser/api/execute_code_function.cc b/extensions/browser/api/execute_code_function.cc
index d1b1ee3a8fe0f37e5c44932ec50d2785d554cfc7..3248c681c3a741b51e09a04e89be84ef76e3d97d 100644
--- a/extensions/browser/api/execute_code_function.cc
+++ b/extensions/browser/api/execute_code_function.cc
@@ -163,7 +163,13 @@ bool ExecuteCodeFunction::HasPermission() {
 }
 
 bool ExecuteCodeFunction::RunAsync() {
-  EXTENSION_FUNCTION_VALIDATE(Init());
+  InitResult init_result = Init();
+  EXTENSION_FUNCTION_VALIDATE(init_result != VALIDATION_FAILURE);
+  if (init_result == FAILURE) {
+    if (init_error_)
+      error_ = init_error_.value();

[Devlin, 2017/01/24 16:09:05]

nit: since you're here, may as well make this SetError()

[lazyboy, 2017/01/24 23:36:07]

Done.

+    return false;
+  }
 
   if (!details_->code.get() && !details_->file.get()) {
     error_ = kNoCodeOrFileToExecuteError;