Separate validation failures from other failures in ExecuteCodeFunction.

extensions/browser/api/guest_view/web_view/web_view_internal_api.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "extensions/browser/api/guest_view/web_view/web_view_internal_api.h"
 
 #include <utility>
 
 #include "base/guid.h"
 #include "base/memory/ptr_util.h"
@@ skipping 347 matching lines @@
   guest_->NavigateGuest(src, true /* force_navigation */);
   return RespondNow(NoArguments());
 }
 
 WebViewInternalExecuteCodeFunction::WebViewInternalExecuteCodeFunction()
     : guest_instance_id_(0) {}
 
 WebViewInternalExecuteCodeFunction::~WebViewInternalExecuteCodeFunction() {
 }
 
-bool WebViewInternalExecuteCodeFunction::Init() {
-  if (details_.get())
-    return true;
+ExecuteCodeFunction::InitResult WebViewInternalExecuteCodeFunction::Init() {
+  if (init_result_)
+    return init_result_.value();
 
-  if (!args_->GetInteger(0, &guest_instance_id_))
-    return false;
-
-  if (!guest_instance_id_)
-    return false;
+  if (!args_->GetInteger(0, &guest_instance_id_) || !guest_instance_id_)
+    return set_init_result(VALIDATION_FAILURE);
 
   std::string src;
   if (!args_->GetString(1, &src))
-    return false;
+    return set_init_result(VALIDATION_FAILURE);
 
   // Set |guest_src_| here, but do not return false if it is invalid.
   // Instead, let it continue with the normal page load sequence,
   // which will result in the usual LOAD_ABORT event in the case where
   // the URL is invalid.
   guest_src_ = GURL(src);
 
   base::DictionaryValue* details_value = NULL;
   if (!args_->GetDictionary(2, &details_value))
-    return false;
+    return set_init_result(VALIDATION_FAILURE);
   std::unique_ptr<InjectDetails> details(new InjectDetails());
   if (!InjectDetails::Populate(*details_value, details.get()))
-    return false;
+    return set_init_result(VALIDATION_FAILURE);
 
   details_ = std::move(details);
 
   if (extension()) {
     set_host_id(HostID(HostID::EXTENSIONS, extension()->id()));
-    return true;
+    return set_init_result(SUCCESS);
   }
 
   WebContents* web_contents = GetSenderWebContents();
   if (web_contents && web_contents->GetWebUI()) {
     const GURL& url = render_frame_host()->GetSiteInstance()->GetSiteURL();
     set_host_id(HostID(HostID::WEBUI, url.spec()));
-    return true;
+    return set_init_result(SUCCESS);
   }
-  return false;
+  return set_init_result_error("");  // TODO(lazyboy): error?
 }
 
 bool WebViewInternalExecuteCodeFunction::ShouldInsertCSS() const {
   return false;
 }
 
 bool WebViewInternalExecuteCodeFunction::CanExecuteScriptOnPage() {
   return true;
 }
 
@@ skipping 559 matching lines @@
   // Will finish asynchronously.
   return true;
 }
 
 void WebViewInternalClearDataFunction::ClearDataDone() {
   Release();  // Balanced in RunAsync().
   SendResponse(true);
 }
 
 }  // namespace extensions