Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Side by Side Diff: chrome/browser/extensions/api/tabs/tabs_constants.cc

Issue 2630753003: Separate validation failures from other failures in ExecuteCodeFunction. (Closed)
Patch Set: address comments Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/extensions/api/tabs/tabs_constants.h" 5 #include "chrome/browser/extensions/api/tabs/tabs_constants.h"
6 6
7 namespace extensions { 7 namespace extensions {
8 namespace tabs_constants { 8 namespace tabs_constants {
9 9
10 const char kActiveKey[] = "active"; 10 const char kActiveKey[] = "active";
(...skipping 63 matching lines...) Expand 10 before | Expand all | Expand 10 after
74 "mode."; 74 "mode.";
75 const char kCanOnlyMoveTabsWithinNormalWindowsError[] = "Tabs can only be " 75 const char kCanOnlyMoveTabsWithinNormalWindowsError[] = "Tabs can only be "
76 "moved to and from normal windows."; 76 "moved to and from normal windows.";
77 const char kCanOnlyMoveTabsWithinSameProfileError[] = "Tabs can only be moved " 77 const char kCanOnlyMoveTabsWithinSameProfileError[] = "Tabs can only be moved "
78 "between windows in the same profile."; 78 "between windows in the same profile.";
79 const char kFrameNotFoundError[] = "No frame with id * in tab *."; 79 const char kFrameNotFoundError[] = "No frame with id * in tab *.";
80 const char kNoCrashBrowserError[] = 80 const char kNoCrashBrowserError[] =
81 "I'm sorry. I'm afraid I can't do that."; 81 "I'm sorry. I'm afraid I can't do that.";
82 const char kNoCurrentWindowError[] = "No current window"; 82 const char kNoCurrentWindowError[] = "No current window";
83 const char kNoLastFocusedWindowError[] = "No last-focused window"; 83 const char kNoLastFocusedWindowError[] = "No last-focused window";
84 const char kNoTabInBrowserWindowError[] = "There is no tab in browser window.";
84 const char kPerOriginOnlyInAutomaticError[] = "Can only set scope to " 85 const char kPerOriginOnlyInAutomaticError[] = "Can only set scope to "
85 "\"per-origin\" in \"automatic\" mode."; 86 "\"per-origin\" in \"automatic\" mode.";
86 const char kWindowNotFoundError[] = "No window with id: *."; 87 const char kWindowNotFoundError[] = "No window with id: *.";
87 const char kTabIndexNotFoundError[] = "No tab at index: *."; 88 const char kTabIndexNotFoundError[] = "No tab at index: *.";
88 const char kTabNotFoundError[] = "No tab with id: *."; 89 const char kTabNotFoundError[] = "No tab with id: *.";
89 const char kCannotDiscardTab[] = "Cannot discard tab with id: *."; 90 const char kCannotDiscardTab[] = "Cannot discard tab with id: *.";
90 const char kCannotFindTabToDiscard[] = "Cannot find a tab to discard."; 91 const char kCannotFindTabToDiscard[] = "Cannot find a tab to discard.";
91 const char kTabStripNotEditableError[] = 92 const char kTabStripNotEditableError[] =
92 "Tabs cannot be edited right now (user may be dragging a tab)."; 93 "Tabs cannot be edited right now (user may be dragging a tab).";
93 const char kNoSelectedTabError[] = "No selected tab"; 94 const char kNoSelectedTabError[] = "No selected tab";
(...skipping 12 matching lines...) Expand all
106 const char kCannotUpdateMuteDisabled[] = 107 const char kCannotUpdateMuteDisabled[] =
107 "Failed to update mute state for tab *, --* must be enabled"; 108 "Failed to update mute state for tab *, --* must be enabled";
108 const char kCannotUpdateMuteCaptured[] = 109 const char kCannotUpdateMuteCaptured[] =
109 "Cannot update mute state for tab *, tab has audio or video currently " 110 "Cannot update mute state for tab *, tab has audio or video currently "
110 "being captured"; 111 "being captured";
111 const char kCannotDetermineLanguageOfUnloadedTab[] = 112 const char kCannotDetermineLanguageOfUnloadedTab[] =
112 "Cannot determine language: tab not loaded"; 113 "Cannot determine language: tab not loaded";
113 114
114 } // namespace tabs_constants 115 } // namespace tabs_constants
115 } // namespace extensions 116 } // namespace extensions
OLDNEW
« no previous file with comments | « chrome/browser/extensions/api/tabs/tabs_constants.h ('k') | extensions/browser/api/execute_code_function.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698