Separate validation failures from other failures in ExecuteCodeFunction.

chrome/browser/extensions/api/tabs/tabs_api_unittest.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/strings/stringprintf.h"
 #include "base/strings/utf_string_conversions.h"
 #include "chrome/browser/extensions/api/tabs/tabs_api.h"
+#include "chrome/browser/extensions/api/tabs/tabs_constants.h"
 #include "chrome/browser/extensions/extension_function_test_utils.h"
 #include "chrome/browser/extensions/extension_service_test_base.h"
 #include "chrome/browser/extensions/extension_tab_util.h"
 #include "chrome/browser/sessions/session_tab_helper.h"
 #include "chrome/browser/ui/browser.h"
 #include "chrome/browser/ui/tabs/tab_strip_model.h"
 #include "chrome/test/base/test_browser_window.h"
 #include "content/public/browser/navigation_entry.h"
 #include "content/public/common/browser_side_navigation_policy.h"
 #include "content/public/test/browser_side_navigation_test_utils.h"
@@ skipping 245 matching lines @@
   EXPECT_EQ(kGoogle, web_contents->GetLastCommittedURL());
   EXPECT_EQ(kGoogle, web_contents->GetVisibleURL());
 
   // Clean up.
   response_helper.WaitForResponse();
   while (!browser()->tab_strip_model()->empty())
     browser()->tab_strip_model()->CloseWebContentsAt(0, 0);
   base::RunLoop().RunUntilIdle();
 }
 
+// Tests that non-validation failure in tabs.executeScript results in error, and
+// not bad_message.
+// Regression test for https://crbug.com/642794.
+TEST_F(TabsApiUnitTest, ExecuteScriptNoTabIsNonFatalError) {
+  scoped_refptr<const Extension> extension = test_util::CreateEmptyExtension();

[Devlin, 2017/01/17 18:52:09]

nit: it seems like this could pretty easily break if we change the ordering of
the permissions check.  Can we give the extension permissions to run so that we
know the only error we can return is the one we expect?

[lazyboy, 2017/01/18 02:29:10]

Done.

+  scoped_refptr<TabsExecuteScriptFunction> function(
+      new TabsExecuteScriptFunction());
+  function->set_extension(extension);
+  const char* kArgs = "[\"\", {\"code\": \"\"}]";
+  std::string error = extension_function_test_utils::RunFunctionAndReturnError(
+      function.get(), kArgs,
+      browser(),  // browser() doesn't have any tabs.
+      extension_function_test_utils::NONE);
+  EXPECT_EQ(tabs_constants::kNoTabInBrowserWindowError, error);
+}
+
 }  // namespace extensions