Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(173)

Unified Diff: pkg/compiler/lib/src/ssa/builder.dart

Issue 2630743002: Remove use of FunctionSignature et al from call_structure.dart (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/compiler/lib/src/ssa/builder.dart
diff --git a/pkg/compiler/lib/src/ssa/builder.dart b/pkg/compiler/lib/src/ssa/builder.dart
index 7cf54fcae9474145a3e946a4463e4404f7c00a54..ba2f2744c90f2b5c8be6837c3c84dc772250ad32 100644
--- a/pkg/compiler/lib/src/ssa/builder.dart
+++ b/pkg/compiler/lib/src/ssa/builder.dart
@@ -1070,7 +1070,7 @@ class SsaBuilder extends ast.Visitor
ConstructorElement target = constructor.definingConstructor.implementation;
bool match = !target.isMalformed &&
- CallStructure.addForwardingElementArgumentsToList(
+ Elements.addForwardingElementArgumentsToList<HInstruction>(
constructor,
arguments,
target,
@@ -1163,7 +1163,8 @@ class SsaBuilder extends ast.Visitor
reporter.internalError(
superClass, "No default constructor available.");
}
- List<HInstruction> arguments = CallStructure.NO_ARGS.makeArgumentsList(
+ List<HInstruction> arguments = Elements.makeArgumentsList<HInstruction>(
+ CallStructure.NO_ARGS,
const Link<ast.Node>(),
target.implementation,
null,
@@ -2547,7 +2548,8 @@ class SsaBuilder extends ast.Visitor
return pop();
}
- return callStructure.makeArgumentsList(
+ return Elements.makeArgumentsList<HInstruction>(
+ callStructure,
arguments,
element,
compileArgument,
@@ -3435,8 +3437,7 @@ class SsaBuilder extends ast.Visitor
// calling [makeStaticArgumentList].
constructorImplementation = constructor.implementation;
if (constructorImplementation.isMalformed ||
- !callStructure
- .signatureApplies(constructorImplementation.functionSignature)) {
+ !callStructure.signatureApplies(constructorImplementation.type)) {
generateWrongArgumentCountError(send, constructor, send.arguments);
return;
}

Powered by Google App Engine
This is Rietveld 408576698