Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Side by Side Diff: third_party/WebKit/Source/modules/accessibility/AXTable.cpp

Issue 2630723002: Fix blink_perf.paint regression about tables (Closed)
Patch Set: Issues fixed in patch set 4 Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2008 Apple Inc. All rights reserved. 2 * Copyright (C) 2008 Apple Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 7 *
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 185 matching lines...) Expand 10 before | Expand all | Expand 10 after
196 unsigned cellsWithBottomBorder = 0; 196 unsigned cellsWithBottomBorder = 0;
197 unsigned cellsWithLeftBorder = 0; 197 unsigned cellsWithLeftBorder = 0;
198 unsigned cellsWithRightBorder = 0; 198 unsigned cellsWithRightBorder = 0;
199 199
200 Color alternatingRowColors[5]; 200 Color alternatingRowColors[5];
201 int alternatingRowColorCount = 0; 201 int alternatingRowColorCount = 0;
202 202
203 int headersInFirstColumnCount = 0; 203 int headersInFirstColumnCount = 0;
204 for (int row = 0; row < numRows; ++row) { 204 for (int row = 0; row < numRows; ++row) {
205 int headersInFirstRowCount = 0; 205 int headersInFirstRowCount = 0;
206 for (int col = 0; col < numCols; ++col) { 206 int nCols = firstBody->numCols(row);
mstensho (USE GERRIT) 2017/01/20 10:02:04 Now there's both numCols and nCols, which is confu
a.suchit 2017/01/23 06:35:32 Done.
207 for (int col = 0; col < nCols; ++col) {
207 LayoutTableCell* cell = firstBody->primaryCellAt(row, col); 208 LayoutTableCell* cell = firstBody->primaryCellAt(row, col);
208 if (!cell) 209 if (!cell)
209 continue; 210 continue;
210 Node* cellNode = cell->node(); 211 Node* cellNode = cell->node();
211 if (!cellNode) 212 if (!cellNode)
212 continue; 213 continue;
213 214
214 if (cell->size().width() < 1 || cell->size().height() < 1) 215 if (cell->size().width() < 1 || cell->size().height() < 1)
215 continue; 216 continue;
216 217
(...skipping 387 matching lines...) Expand 10 before | Expand all | Expand 10 after
604 } 605 }
605 606
606 DEFINE_TRACE(AXTable) { 607 DEFINE_TRACE(AXTable) {
607 visitor->trace(m_rows); 608 visitor->trace(m_rows);
608 visitor->trace(m_columns); 609 visitor->trace(m_columns);
609 visitor->trace(m_headerContainer); 610 visitor->trace(m_headerContainer);
610 AXLayoutObject::trace(visitor); 611 AXLayoutObject::trace(visitor);
611 } 612 }
612 613
613 } // namespace blink 614 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698