Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(520)

Unified Diff: third_party/WebKit/Source/core/frame/LocalFrame.cpp

Issue 2630693002: Make ScriptController inherit LocalWindowProxyManager
Patch Set: rebase Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/frame/LocalFrame.cpp
diff --git a/third_party/WebKit/Source/core/frame/LocalFrame.cpp b/third_party/WebKit/Source/core/frame/LocalFrame.cpp
index 1d711cb31da6bb8da232d4b21a31b29fb9ba14e7..a84b71892cac14c505bd9e08314d7d05e9c0933a 100644
--- a/third_party/WebKit/Source/core/frame/LocalFrame.cpp
+++ b/third_party/WebKit/Source/core/frame/LocalFrame.cpp
@@ -362,10 +362,6 @@ DEFINE_TRACE(LocalFrame) {
Supplementable<LocalFrame>::trace(visitor);
}
-WindowProxy* LocalFrame::windowProxy(DOMWrapperWorld& world) {
- return m_script->windowProxy(world);
-}
-
void LocalFrame::navigate(Document& originDocument,
const KURL& url,
bool replaceCurrentItem,
@@ -495,7 +491,7 @@ void LocalFrame::printNavigationWarning(const String& message) {
}
WindowProxyManagerBase* LocalFrame::getWindowProxyManager() const {
- return m_script->getWindowProxyManager();
+ return m_script;
}
bool LocalFrame::shouldClose() {
@@ -523,7 +519,7 @@ LocalDOMWindow* LocalFrame::domWindow() const {
void LocalFrame::setDOMWindow(LocalDOMWindow* domWindow) {
if (domWindow)
- script().clearWindowProxy();
+ script().clearForNavigation();
if (this->domWindow())
this->domWindow()->reset();
@@ -884,7 +880,7 @@ inline LocalFrame::LocalFrame(FrameLoaderClient* client,
client->frameBlameContext())),
m_loader(this),
m_navigationScheduler(NavigationScheduler::create(this)),
- m_script(ScriptController::create(this)),
+ m_script(ScriptController::create(*this)),
m_editor(Editor::create(*this)),
m_spellChecker(SpellChecker::create(*this)),
m_selection(FrameSelection::create(*this)),
« no previous file with comments | « third_party/WebKit/Source/core/frame/LocalFrame.h ('k') | third_party/WebKit/Source/core/frame/RemoteFrame.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698