Make ScriptController inherit LocalWindowProxyManager

third_party/WebKit/Source/bindings/core/v8/ScriptController.h

 /*
  * Copyright (C) 2008, 2009 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 29 matching lines @@
 #include "platform/heap/Handle.h"
 #include "wtf/HashMap.h"
 #include "wtf/Noncopyable.h"
 #include "wtf/Vector.h"
 #include "wtf/text/TextPosition.h"
 #include <v8.h>
 
 namespace blink {
 
 class CompiledScript;
-class DOMWrapperWorld;
 class Element;
 class KURL;
 class ScriptSourceCode;
 class SecurityOrigin;
 class Widget;
 
 typedef WTF::Vector<v8::Extension*> V8Extensions;
 
 enum ReasonForCallingCanExecuteScripts {
   AboutToExecuteScript,
   NotAboutToExecuteScript
 };
 
-class CORE_EXPORT ScriptController final
-    : public GarbageCollected<ScriptController> {
+class CORE_EXPORT ScriptController final : public LocalWindowProxyManager {

[Yuki, 2017/01/13 10:42:00]

If possible, could you elaborate what ScriptController's responsibilities are
and what (Local)WindowProxyManager's responsibilities are?

[dcheng, 2017/01/13 18:57:30]

Done.

   WTF_MAKE_NONCOPYABLE(ScriptController);
 
  public:
   enum ExecuteScriptPolicy {
     ExecuteScriptWhenScriptsDisabled,
     DoNotExecuteScriptWhenScriptsDisabled
   };
 
-  static ScriptController* create(LocalFrame* frame) {
+  static ScriptController* create(LocalFrame& frame) {
     return new ScriptController(frame);
   }
 
-  DECLARE_TRACE();
-
-  // This returns an initialized window proxy. (If the window proxy is not
-  // yet initialized, it's implicitly initialized at the first access.)
-  LocalWindowProxy* windowProxy(DOMWrapperWorld&);
-
   // Evaluate JavaScript in the main world.
   void executeScriptInMainWorld(
       const String&,
       ExecuteScriptPolicy = DoNotExecuteScriptWhenScriptsDisabled);
   void executeScriptInMainWorld(const ScriptSourceCode&,
                                 AccessControlStatus = NotSharableCrossOrigin);
   v8::Local<v8::Value> executeScriptInMainWorldAndReturnValue(
       const ScriptSourceCode&,
       ExecuteScriptPolicy = DoNotExecuteScriptWhenScriptsDisabled);
   v8::Local<v8::Value> executeScriptAndReturnValue(
@@ skipping 31 matching lines @@
 
   PassRefPtr<SharedPersistent<v8::Object>> createPluginWrapper(Widget*);
 
   void enableEval();
   void disableEval(const String& errorMessage);
 
   bool canExecuteScripts(ReasonForCallingCanExecuteScripts);
 
   TextPosition eventHandlerPosition() const;
 
-  void clearWindowProxy();
+  void clearForClose();
+  void clearForNavigation();
   void updateDocument();
-
   void updateSecurityOrigin(SecurityOrigin*);
 
-  void clearForClose();
-
   // Registers a v8 extension to be available on webpages. Will only
   // affect v8 contexts initialized after this call. Takes ownership of
   // the v8::Extension object passed.
   static void registerExtensionIfNeeded(v8::Extension*);
   static V8Extensions& registeredExtensions();
 
-  v8::Isolate* isolate() const { return m_windowProxyManager->isolate(); }
-
-  LocalWindowProxyManager* getWindowProxyManager() const {
-    return m_windowProxyManager.get();
-  }
-
  private:
-  explicit ScriptController(LocalFrame*);
-
-  LocalFrame* frame() const { return m_windowProxyManager->frame(); }
+  explicit ScriptController(LocalFrame&);
 
   v8::Local<v8::Value> evaluateScriptInMainWorld(const ScriptSourceCode&,
                                                  AccessControlStatus,
                                                  ExecuteScriptPolicy);
-
-  Member<LocalWindowProxyManager> m_windowProxyManager;
 };
 
 }  // namespace blink
 
 #endif  // ScriptController_h