Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2402)

Unified Diff: content/public/test/browser_test_base.cc

Issue 2630683003: Revert of Convert more test helpers to base::RunLoop, fix page title checks. (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/browser_browsertest.cc ('k') | content/public/test/browser_test_utils.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/public/test/browser_test_base.cc
diff --git a/content/public/test/browser_test_base.cc b/content/public/test/browser_test_base.cc
index cdfde3472a60256e4106913da06c327079886974..2333cceee12396f5938785a2917750cb748aeeef 100644
--- a/content/public/test/browser_test_base.cc
+++ b/content/public/test/browser_test_base.cc
@@ -341,14 +341,7 @@
TracingController::StartTracingDoneCallback());
}
- {
- // This can be called from a posted task. Allow nested tasks here, because
- // otherwise the test body will have to do it in order to use RunLoop for
- // waiting.
- base::MessageLoop::ScopedNestableTaskAllower allow(
- base::MessageLoop::current());
- RunTestOnMainThreadLoop();
- }
+ RunTestOnMainThreadLoop();
if (base::CommandLine::ForCurrentProcess()->HasSwitch(
switches::kEnableTracing)) {
« no previous file with comments | « chrome/browser/ui/browser_browsertest.cc ('k') | content/public/test/browser_test_utils.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698