Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2630633002: dart2js-kernel: special-case InvalidType in 'is' and 'as' (Closed)

Created:
3 years, 11 months ago by sra1
Modified:
3 years, 11 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

dart2js-kernel: special-case InvalidType in 'is' and 'as' BUG= R=sigmund@google.com Committed: https://github.com/dart-lang/sdk/commit/d47c12da3162c3fcc5af556f64f66dfe3c1977c4

Patch Set 1 #

Patch Set 2 : handle invalid return types #

Patch Set 3 : format #

Total comments: 4

Patch Set 4 : fix and format #

Unified diffs Side-by-side diffs Delta from patch set Stats (+78 lines, -36 lines) Patch
M pkg/compiler/lib/src/ssa/builder_kernel.dart View 1 2 3 9 chunks +48 lines, -31 lines 0 comments Download
M pkg/compiler/lib/src/ssa/kernel_ast_adapter.dart View 1 2 3 5 chunks +30 lines, -5 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
sra1
3 years, 11 months ago (2017-01-13 04:02:42 UTC) #2
Siggi Cherem (dart-lang)
lgtm https://codereview.chromium.org/2630633002/diff/40001/pkg/compiler/lib/src/ssa/kernel_ast_adapter.dart File pkg/compiler/lib/src/ssa/kernel_ast_adapter.dart (right): https://codereview.chromium.org/2630633002/diff/40001/pkg/compiler/lib/src/ssa/kernel_ast_adapter.dart#newcode516 pkg/compiler/lib/src/ssa/kernel_ast_adapter.dart:516: ResolutionDartType getDartTypeInvalidNull(ir.DartType type) { nit: rename, some ideas: ...
3 years, 11 months ago (2017-01-13 16:36:14 UTC) #3
Siggi Cherem (dart-lang)
https://codereview.chromium.org/2630633002/diff/40001/pkg/compiler/lib/src/ssa/builder_kernel.dart File pkg/compiler/lib/src/ssa/builder_kernel.dart (right): https://codereview.chromium.org/2630633002/diff/40001/pkg/compiler/lib/src/ssa/builder_kernel.dart#newcode2469 pkg/compiler/lib/src/ssa/builder_kernel.dart:2469: kernelBuilder.stack.add(kernelBuilder.graph actually - should we handle `guard is DynamicType` ...
3 years, 11 months ago (2017-01-13 16:38:22 UTC) #4
sra1
https://codereview.chromium.org/2630633002/diff/40001/pkg/compiler/lib/src/ssa/builder_kernel.dart File pkg/compiler/lib/src/ssa/builder_kernel.dart (right): https://codereview.chromium.org/2630633002/diff/40001/pkg/compiler/lib/src/ssa/builder_kernel.dart#newcode2469 pkg/compiler/lib/src/ssa/builder_kernel.dart:2469: kernelBuilder.stack.add(kernelBuilder.graph On 2017/01/13 16:38:22, Siggi Cherem (dart-lang) wrote: > ...
3 years, 11 months ago (2017-01-13 18:53:11 UTC) #5
sra1
3 years, 11 months ago (2017-01-13 20:08:32 UTC) #7
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) manually as
d47c12da3162c3fcc5af556f64f66dfe3c1977c4 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698