[Sync] USS: Filter out tombstones for initial sync.

components/sync/engine_impl/test_entry_factory.cc

 // Copyright 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/sync/engine_impl/test_entry_factory.h"
 
 #include "components/sync/base/hash_util.h"
 #include "components/sync/base/model_type.h"
 #include "components/sync/syncable/directory.h"
 #include "components/sync/syncable/entry.h"
@@ skipping 182 matching lines @@
   if (specifics.ByteSize() > 0) {
     entry.PutSpecifics(specifics);
     entry.PutServerSpecifics(specifics);
   } else {
     entry.PutServerSpecifics(entry.GetSpecifics());
   }
 
   return entry.GetMetahandle();
 }
 
+int64_t TestEntryFactory::CreateTombstone(const std::string& name,

[skym, 2017/01/13 16:31:23]

It seems like there's a lot of duplicated logic between this and
CreateSyncedItem. Is there a reason that consolidating this logic somewhere
shared isn't easy?

[maxbogue, 2017/01/17 22:02:26]

Done.

+                                          ModelType model_type) {
+  WriteTransaction trans(FROM_HERE, UNITTEST, directory_);
+
+  // Use the type root if it exists or the real root otherwise.
+  syncable::Entry root(&trans, syncable::GET_TYPE_ROOT, model_type);
+  syncable::Id parent_id = root.good() ? root.GetId() : TestIdFactory::root();
+  syncable::Id item_id(TestIdFactory::MakeServer(name));
+  int64_t version = GetNextRevision();
+  base::Time now = base::Time::Now();
+
+  MutableEntry entry(&trans, syncable::CREATE, model_type, parent_id, name);
+  if (!entry.good()) {
+    NOTREACHED();
+    return syncable::kInvalidMetaHandle;
+  }
+
+  entry.PutId(item_id);
+  entry.PutCtime(now);
+  entry.PutMtime(now);
+  entry.PutUniqueClientTag(GenerateSyncableHash(model_type, name));
+  entry.PutBaseVersion(version);
+  entry.PutIsUnsynced(false);
+  entry.PutNonUniqueName(name);
+  entry.PutIsDir(false);
+  entry.PutIsDel(true);
+  entry.PutParentId(parent_id);
+
+  entry.PutServerCtime(now);
+  entry.PutServerMtime(now);
+  entry.PutServerVersion(version);
+  entry.PutIsUnappliedUpdate(false);
+  entry.PutServerNonUniqueName(name);
+  entry.PutServerParentId(parent_id);
+  entry.PutServerIsDir(false);
+  entry.PutServerIsDel(true);
+
+  return entry.GetMetahandle();
+}
+
 int64_t TestEntryFactory::CreateTypeRootNode(ModelType model_type) {
   syncable::ModelNeutralWriteTransaction trans(FROM_HERE, syncable::UNITTEST,
                                                directory_);
   sync_pb::EntitySpecifics specifics;
   AddDefaultFieldValue(model_type, &specifics);
   syncable::ModelNeutralMutableEntry entry(
       &trans, syncable::CREATE_NEW_TYPE_ROOT, model_type);
   DCHECK(entry.good());
   entry.PutServerIsDir(true);
   entry.PutUniqueServerTag(ModelTypeToRootTag(model_type));
@@ skipping 124 matching lines @@
     return false;
   }
   return entry.GetIsUnappliedUpdate();
 }
 
 int64_t TestEntryFactory::GetNextRevision() {
   return next_revision_++;
 }
 
 }  // namespace syncer