Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(170)

Issue 26306002: Move ScrollTypes.h from Source/core/platform to Source/platform/scroll. (Closed)

Created:
7 years, 2 months ago by atreat
Modified:
7 years, 2 months ago
Reviewers:
abarth-chromium
CC:
blink-reviews, kenneth.christiansen, shans, rjwright, alancutter (OOO until 2018), Mike Lawther (Google), eae+blinkwatch, Timothy Loh, leviw+renderwatch, blink-layers+watch_chromium.org, dstockwell, dglazkov+blink, apavlov+blink_chromium.org, adamk+blink_chromium.org, jchaffraix+rendering, darktears, Steve Block, dino_apple.com, Eric Willigers
Base URL:
https://chromium.googlesource.com/chromium/blink@master
Visibility:
Public.

Description

Move ScrollTypes.h from Source/core/platform to Source/platform/scroll. BUG=297477 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=159056

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+179 lines, -186 lines) Patch
M Source/core/css/PseudoStyleRequest.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/Element.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLFrameElementBase.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/page/ChromeClient.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/page/EventHandler.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/page/Frame.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/page/scrolling/ScrollingCoordinator.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/platform/PopupMenuClient.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/platform/ScrollAnimator.h View 1 chunk +1 line, -1 line 0 comments Download
D Source/core/platform/ScrollTypes.h View 1 chunk +0 lines, -166 lines 0 comments Download
M Source/core/platform/ScrollView.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/platform/Scrollbar.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/platform/ScrollbarTheme.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/platform/ScrollbarThemeClient.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/platform/mac/ScrollElasticityController.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/plugins/PluginView.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderBox.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderScrollbarPart.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderTheme.h View 2 chunks +1 line, -1 line 0 comments Download
M Source/platform/blink_platform.gypi View 1 chunk +1 line, -0 lines 0 comments Download
A Source/platform/scroll/ScrollTypes.h View 1 chunk +158 lines, -0 lines 0 comments Download
M Source/web/WebFrameImpl.cpp View 2 chunks +1 line, -1 line 0 comments Download
M Source/web/WebPluginScrollbarImpl.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
atreat
This moves ScrollTypes.h to platform/scroll. It depends upon this being applied first: https://codereview.chromium.org/26296002/ I also ...
7 years, 2 months ago (2013-10-07 18:15:48 UTC) #1
abarth-chromium
lgtm
7 years, 2 months ago (2013-10-07 19:19:26 UTC) #2
abarth-chromium
Thanks for working on this!
7 years, 2 months ago (2013-10-07 19:19:49 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/adam.treat@samsung.com/26306002/1
7 years, 2 months ago (2013-10-07 20:03:15 UTC) #4
commit-bot: I haz the power
7 years, 2 months ago (2013-10-07 22:21:53 UTC) #5
Message was sent while issue was closed.
Change committed as 159056

Powered by Google App Engine
This is Rietveld 408576698