Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(544)

Side by Side Diff: chrome/browser/ui/zoom/chrome_zoom_level_otr_delegate.cc

Issue 2630583002: Add setting to isolate zoom changes by default. (Closed)
Patch Set: Add more tests. Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/zoom/chrome_zoom_level_otr_delegate.h" 5 #include "chrome/browser/ui/zoom/chrome_zoom_level_otr_delegate.h"
6 6
7 #include "base/bind.h" 7 #include "base/bind.h"
8 #include "chrome/browser/ui/zoom/chrome_zoom_level_prefs.h"
8 #include "components/zoom/zoom_event_manager.h" 9 #include "components/zoom/zoom_event_manager.h"
9 10
10 ChromeZoomLevelOTRDelegate::ChromeZoomLevelOTRDelegate( 11 ChromeZoomLevelOTRDelegate::ChromeZoomLevelOTRDelegate(
11 base::WeakPtr<zoom::ZoomEventManager> zoom_event_manager) 12 base::WeakPtr<zoom::ZoomEventManager> zoom_event_manager,
12 : zoom_event_manager_(zoom_event_manager), host_zoom_map_(nullptr) {} 13 ChromeZoomLevelPrefs* parent_zoom_level_prefs)
14 : zoom_event_manager_(zoom_event_manager), host_zoom_map_(nullptr),
15 parent_zoom_level_prefs_(parent_zoom_level_prefs) {}
13 16
14 ChromeZoomLevelOTRDelegate::~ChromeZoomLevelOTRDelegate() { 17 ChromeZoomLevelOTRDelegate::~ChromeZoomLevelOTRDelegate() {
15 } 18 }
16 19
20 bool ChromeZoomLevelOTRDelegate::GetIsOriginScopePref() const {
21 if (!parent_zoom_level_prefs_)
wjmaclean 2017/01/19 21:09:05 Is this null for Guest browsing mode? If so, perha
Kevin McNee 2017/01/25 16:41:52 This is no longer used.
22 return true;
23
24 // Just use the setting of the parent profile.
25 return parent_zoom_level_prefs_->GetIsOriginScopePref();
26 }
27
28 std::unique_ptr<ChromeZoomLevelOTRDelegate::DefaultZoomScopeSubscription>
29 ChromeZoomLevelOTRDelegate::RegisterDefaultZoomScopeCallback(
30 const base::Closure& callback) {
31 if (!parent_zoom_level_prefs_)
32 return nullptr;
33
34 return parent_zoom_level_prefs_->RegisterDefaultZoomScopeCallback(callback);
35 }
36
17 void ChromeZoomLevelOTRDelegate::InitHostZoomMap( 37 void ChromeZoomLevelOTRDelegate::InitHostZoomMap(
18 content::HostZoomMap* host_zoom_map) { 38 content::HostZoomMap* host_zoom_map) {
19 // This init function must be called only once. 39 // This init function must be called only once.
20 DCHECK(!host_zoom_map_); 40 DCHECK(!host_zoom_map_);
21 DCHECK(host_zoom_map); 41 DCHECK(host_zoom_map);
22 host_zoom_map_ = host_zoom_map; 42 host_zoom_map_ = host_zoom_map;
23 43
24 zoom_subscription_ = host_zoom_map_->AddZoomLevelChangedCallback(base::Bind( 44 zoom_subscription_ = host_zoom_map_->AddZoomLevelChangedCallback(base::Bind(
25 &ChromeZoomLevelOTRDelegate::OnZoomLevelChanged, base::Unretained(this))); 45 &ChromeZoomLevelOTRDelegate::OnZoomLevelChanged, base::Unretained(this)));
26 } 46 }
27 47
28 void ChromeZoomLevelOTRDelegate::OnZoomLevelChanged( 48 void ChromeZoomLevelOTRDelegate::OnZoomLevelChanged(
29 const content::HostZoomMap::ZoomLevelChange& change) { 49 const content::HostZoomMap::ZoomLevelChange& change) {
30 // If there's a manager to aggregate ZoomLevelChanged events, pass this event 50 // If there's a manager to aggregate ZoomLevelChanged events, pass this event
31 // along. Since we already hold a subscription to our associated HostZoomMap, 51 // along. Since we already hold a subscription to our associated HostZoomMap,
32 // we don't need to create a separate subscription for this. 52 // we don't need to create a separate subscription for this.
33 if (zoom_event_manager_) 53 if (zoom_event_manager_)
34 zoom_event_manager_->OnZoomLevelChanged(change); 54 zoom_event_manager_->OnZoomLevelChanged(change);
35 } 55 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698