Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(242)

Side by Side Diff: chrome/browser/ui/webui/options/browser_options_handler.h

Issue 2630583002: Add setting to isolate zoom changes by default. (Closed)
Patch Set: Use code review comments for questions instead of TODOs. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_UI_WEBUI_OPTIONS_BROWSER_OPTIONS_HANDLER_H_ 5 #ifndef CHROME_BROWSER_UI_WEBUI_OPTIONS_BROWSER_OPTIONS_HANDLER_H_
6 #define CHROME_BROWSER_UI_WEBUI_OPTIONS_BROWSER_OPTIONS_HANDLER_H_ 6 #define CHROME_BROWSER_UI_WEBUI_OPTIONS_BROWSER_OPTIONS_HANDLER_H_
7 7
8 #include <memory> 8 #include <memory>
9 #include <string> 9 #include <string>
10 #include <vector> 10 #include <vector>
(...skipping 239 matching lines...) Expand 10 before | Expand all | Expand 10 after
250 // Callback for the "defaultFontSizeAction" message. This is called if the 250 // Callback for the "defaultFontSizeAction" message. This is called if the
251 // user changes the default font size. |args| is an array that contains 251 // user changes the default font size. |args| is an array that contains
252 // one item, the font size as a numeric value. 252 // one item, the font size as a numeric value.
253 void HandleDefaultFontSize(const base::ListValue* args); 253 void HandleDefaultFontSize(const base::ListValue* args);
254 254
255 // Callback for the "defaultZoomFactorAction" message. This is called if the 255 // Callback for the "defaultZoomFactorAction" message. This is called if the
256 // user changes the default zoom factor. |args| is an array that contains 256 // user changes the default zoom factor. |args| is an array that contains
257 // one item, the zoom factor as a numeric value. 257 // one item, the zoom factor as a numeric value.
258 void HandleDefaultZoomFactor(const base::ListValue* args); 258 void HandleDefaultZoomFactor(const base::ListValue* args);
259 259
260 // Callback for the "defaultZoomScopeAction" message. This is called if the
261 // user toggles the default zoom scope checkbox.
262 // |args| will contain the checkbox checked state as a boolean.
263 void HandleDefaultZoomScope(const base::ListValue* args);
264
260 // Callback for the "Use SSL 3.0" checkbox. This is called if the user toggles 265 // Callback for the "Use SSL 3.0" checkbox. This is called if the user toggles
261 // the "Use SSL 3.0" checkbox. 266 // the "Use SSL 3.0" checkbox.
262 void HandleUseSSL3Checkbox(const base::ListValue* args); 267 void HandleUseSSL3Checkbox(const base::ListValue* args);
263 268
264 // Callback for the "Use TLS 1.0" checkbox. This is called if the user toggles 269 // Callback for the "Use TLS 1.0" checkbox. This is called if the user toggles
265 // the "Use TLS 1.0" checkbox. 270 // the "Use TLS 1.0" checkbox.
266 void HandleUseTLS1Checkbox(const base::ListValue* args); 271 void HandleUseTLS1Checkbox(const base::ListValue* args);
267 272
268 // Callback for the "restartBrowser" message. Restores all tabs on restart. 273 // Callback for the "restartBrowser" message. Restores all tabs on restart.
269 void HandleRestartBrowser(const base::ListValue* args); 274 void HandleRestartBrowser(const base::ListValue* args);
(...skipping 80 matching lines...) Expand 10 before | Expand all | Expand 10 after
350 355
351 // Update value of predictive network actions UI element. 356 // Update value of predictive network actions UI element.
352 void SetupNetworkPredictionControl(); 357 void SetupNetworkPredictionControl();
353 358
354 // Setup the font size selector control. 359 // Setup the font size selector control.
355 void SetupFontSizeSelector(); 360 void SetupFontSizeSelector();
356 361
357 // Setup the page zoom selector control. 362 // Setup the page zoom selector control.
358 void SetupPageZoomSelector(); 363 void SetupPageZoomSelector();
359 364
365 // Setup the default zoom scope checkbox.
366 void SetupZoomScopeCheckbox();
367
360 // Setup the visibility of the reset button. 368 // Setup the visibility of the reset button.
361 void SetupAutoOpenFileTypes(); 369 void SetupAutoOpenFileTypes();
362 370
363 // Setup the proxy settings section UI. 371 // Setup the proxy settings section UI.
364 void SetupProxySettingsSection(); 372 void SetupProxySettingsSection();
365 373
366 // Setup the UI specific to managing supervised users. 374 // Setup the UI specific to managing supervised users.
367 void SetupManagingSupervisedUsers(); 375 void SetupManagingSupervisedUsers();
368 376
369 // Setup the UI for Easy Unlock. 377 // Setup the UI for Easy Unlock.
(...skipping 53 matching lines...) Expand 10 before | Expand all | Expand 10 after
423 TemplateURLService* template_url_service_; // Weak. 431 TemplateURLService* template_url_service_; // Weak.
424 432
425 scoped_refptr<ui::SelectFileDialog> select_folder_dialog_; 433 scoped_refptr<ui::SelectFileDialog> select_folder_dialog_;
426 434
427 bool cloud_print_mdns_ui_enabled_; 435 bool cloud_print_mdns_ui_enabled_;
428 436
429 StringPrefMember auto_open_files_; 437 StringPrefMember auto_open_files_;
430 438
431 std::unique_ptr<ChromeZoomLevelPrefs::DefaultZoomLevelSubscription> 439 std::unique_ptr<ChromeZoomLevelPrefs::DefaultZoomLevelSubscription>
432 default_zoom_level_subscription_; 440 default_zoom_level_subscription_;
441 std::unique_ptr<ChromeZoomLevelPrefs::DefaultZoomScopeSubscription>
442 default_zoom_scope_subscription_;
433 443
434 PrefChangeRegistrar profile_pref_registrar_; 444 PrefChangeRegistrar profile_pref_registrar_;
435 #if defined(OS_CHROMEOS) 445 #if defined(OS_CHROMEOS)
436 std::unique_ptr<policy::PolicyChangeRegistrar> policy_registrar_; 446 std::unique_ptr<policy::PolicyChangeRegistrar> policy_registrar_;
437 447
438 // Whether factory reset can be performed. 448 // Whether factory reset can be performed.
439 bool enable_factory_reset_; 449 bool enable_factory_reset_;
440 450
441 PrefChangeRegistrar local_state_pref_change_registrar_; 451 PrefChangeRegistrar local_state_pref_change_registrar_;
442 #endif 452 #endif
443 453
444 ScopedObserver<SigninManagerBase, SigninManagerBase::Observer> 454 ScopedObserver<SigninManagerBase, SigninManagerBase::Observer>
445 signin_observer_; 455 signin_observer_;
446 456
447 // Used to get WeakPtr to self for use on the UI thread. 457 // Used to get WeakPtr to self for use on the UI thread.
448 base::WeakPtrFactory<BrowserOptionsHandler> weak_ptr_factory_; 458 base::WeakPtrFactory<BrowserOptionsHandler> weak_ptr_factory_;
449 459
450 DISALLOW_COPY_AND_ASSIGN(BrowserOptionsHandler); 460 DISALLOW_COPY_AND_ASSIGN(BrowserOptionsHandler);
451 }; 461 };
452 462
453 } // namespace options 463 } // namespace options
454 464
455 #endif // CHROME_BROWSER_UI_WEBUI_OPTIONS_BROWSER_OPTIONS_HANDLER_H_ 465 #endif // CHROME_BROWSER_UI_WEBUI_OPTIONS_BROWSER_OPTIONS_HANDLER_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698