Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7226)

Unified Diff: chrome/browser/ui/views/toolbar/toolbar_actions_bar_bubble_views_unittest.cc

Issue 2630473003: MacViews: Harmony for toolbar actions bubbles. (Closed)
Patch Set: respond to comments Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/views/toolbar/toolbar_actions_bar_bubble_views.cc ('k') | chrome/test/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/views/toolbar/toolbar_actions_bar_bubble_views_unittest.cc
diff --git a/chrome/browser/ui/views/toolbar/toolbar_actions_bar_bubble_views_unittest.cc b/chrome/browser/ui/views/toolbar/toolbar_actions_bar_bubble_views_unittest.cc
index 0bea122ba525c1e96b077100c2e1005d62dc8a51..d8b49942761266a9c18f3868bd8bb398cbf68f13 100644
--- a/chrome/browser/ui/views/toolbar/toolbar_actions_bar_bubble_views_unittest.cc
+++ b/chrome/browser/ui/views/toolbar/toolbar_actions_bar_bubble_views_unittest.cc
@@ -63,8 +63,10 @@ class ToolbarActionsBarBubbleViewsTest : public views::ViewsTestBase {
ASSERT_FALSE(bubble_widget_);
ASSERT_FALSE(bubble_);
anchor_widget_ = CreateAnchorWidget();
+ bool anchored_to_action = false;
bubble_ = new ToolbarActionsBarBubbleViews(
- anchor_widget_->GetContentsView(), delegate->GetDelegate());
+ anchor_widget_->GetContentsView(), gfx::Point(), anchored_to_action,
+ delegate->GetDelegate());
bubble_widget_ = views::BubbleDialogDelegateView::CreateBubble(bubble_);
bubble_->Show();
}
@@ -209,7 +211,8 @@ TEST_F(ToolbarActionsBarBubbleViewsTest, TestShowAndCloseBubble) {
ActionString());
delegate.set_dismiss_button_text(DismissString());
ToolbarActionsBarBubbleViews* bubble = new ToolbarActionsBarBubbleViews(
- anchor_widget->GetContentsView(), delegate.GetDelegate());
+ anchor_widget->GetContentsView(), gfx::Point(), false,
+ delegate.GetDelegate());
EXPECT_FALSE(delegate.shown());
EXPECT_FALSE(delegate.close_action());
« no previous file with comments | « chrome/browser/ui/views/toolbar/toolbar_actions_bar_bubble_views.cc ('k') | chrome/test/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698