Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6986)

Unified Diff: chrome/browser/ui/extensions/extension_message_bubble_browsertest.h

Issue 2630473003: MacViews: Harmony for toolbar actions bubbles. (Closed)
Patch Set: respond to comments Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/extensions/extension_message_bubble_browsertest.h
diff --git a/chrome/browser/ui/extensions/extension_message_bubble_browsertest.h b/chrome/browser/ui/extensions/extension_message_bubble_browsertest.h
index bfa131d2b75ec4da07b73fb5a1ca2c15ee5efcbc..de8d7fdc593dd3026130598867c99f8c6ba46bc7 100644
--- a/chrome/browser/ui/extensions/extension_message_bubble_browsertest.h
+++ b/chrome/browser/ui/extensions/extension_message_bubble_browsertest.h
@@ -14,6 +14,8 @@ namespace extensions {
class TestExtensionDir;
}
+class ToolbarActionsBarBubbleViews;
+
class ExtensionMessageBubbleBrowserTest
: public BrowserActionsBarBrowserTest {
protected:
@@ -25,6 +27,16 @@ class ExtensionMessageBubbleBrowserTest
ExtensionMessageBubbleBrowserTest();
~ExtensionMessageBubbleBrowserTest() override;
+ // Returns the toolkit-views bubble that is currently attached to |browser|.
+ // Returns null if there is no bubble showing. Implemented in platform files.
+ static ToolbarActionsBarBubbleViews* GetViewsBubbleForBrowser(
+ Browser* browser);
+
+ // Returns the expected test anchor bounds on |browser| which may be a Cocoa
+ // browser or a Views browser. Implemented in platform files.
+ static gfx::Rect GetAnchorReferenceBoundsForBrowser(Browser* browser,
+ AnchorPosition anchor);
+
// BrowserActionsBarBrowserTest:
void SetUpCommandLine(base::CommandLine* command_line) override;
void TearDownOnMainThread() override;
@@ -39,7 +51,7 @@ class ExtensionMessageBubbleBrowserTest
virtual void CheckBubbleNative(Browser* browser, AnchorPosition anchor) = 0;
// Closes the bubble present in the given |browser|.
- void CloseBubble(Browser* browser);
+ virtual void CloseBubble(Browser* browser);
// Performs the platform-specific close.
virtual void CloseBubbleNative(Browser* browser) = 0;

Powered by Google App Engine
This is Rietveld 408576698