Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4495)

Unified Diff: chrome/browser/ui/cocoa/extensions/browser_actions_controller.h

Issue 2630473003: MacViews: Harmony for toolbar actions bubbles. (Closed)
Patch Set: Fix DialogBrowserTest Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/cocoa/extensions/browser_actions_controller.h
diff --git a/chrome/browser/ui/cocoa/extensions/browser_actions_controller.h b/chrome/browser/ui/cocoa/extensions/browser_actions_controller.h
index 1c8ebe70305a983724779ffd146bc6278ccf7c8c..319de8136e3926cf5df8cea853d5fd3d96d59fbf 100644
--- a/chrome/browser/ui/cocoa/extensions/browser_actions_controller.h
+++ b/chrome/browser/ui/cocoa/extensions/browser_actions_controller.h
@@ -19,6 +19,7 @@ class Browser;
@class MenuButton;
class ToolbarActionsBar;
@class ToolbarActionsBarBubbleMac;
+class ToolbarActionsBarBubbleViewsPresenter;
class ToolbarActionsBarDelegate;
namespace content {
@@ -58,6 +59,9 @@ extern NSString* const kBrowserActionVisibilityChangedNotification;
// The index of the currently-focused view in the overflow menu, or -1 if
// no view is focused.
NSInteger focusedViewIndex_;
+
+ // Bridge for showing the toolkit-views bubble on a Cocoa browser.
+ std::unique_ptr<ToolbarActionsBarBubbleViewsPresenter> viewsBubblePresenter_;
}
@property(nonatomic) CGFloat maxWidth;
@@ -109,6 +113,10 @@ extern NSString* const kBrowserActionVisibilityChangedNotification;
// Returns the size for the provided |maxWidth| of the overflow menu.
- (gfx::Size)sizeForOverflowWidth:(int)maxWidth;
+// Called when the window for the active bubble is closing, and sets the active
+// bubble to nil.
+- (void)bubbleWindowClosing:(NSNotification*)notification;
+
@end // @interface BrowserActionsController
@interface BrowserActionsController(TestingAPI)

Powered by Google App Engine
This is Rietveld 408576698