MacViews: Harmony for toolbar actions bubbles.

chrome/browser/ui/test/test_browser_dialog.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/test/test_browser_dialog.h"
 
 #include "base/command_line.h"
 #include "base/message_loop/message_loop.h"
+#include "base/stl_util.h"
 #include "base/test/gtest_util.h"
 #include "base/threading/thread_task_runner_handle.h"
 #include "chrome/browser/platform_util.h"
 #include "ui/base/material_design/material_design_controller.h"
 #include "ui/base/test/material_design_controller_test_api.h"
 #include "ui/base/test/user_interactive_test_case.h"
 #include "ui/base/ui_base_switches.h"
 #include "ui/views/test/widget_test.h"
 #include "ui/views/widget/widget.h"
 #include "ui/views/widget/widget_observer.h"
@@ skipping 85 matching lines @@
   views::Widget::Widgets widgets_after =
       views::test::WidgetTest::GetAllWidgets();
 #if defined(OS_CHROMEOS)
   views::Widget::GetAllChildWidgets(ash::Shell::GetPrimaryRootWindow(),
                                     &widgets_after);
 #endif  // OS_CHROMEOS
 
   auto added = base::STLSetDifference<std::vector<views::Widget*>>(
       widgets_after, widgets_before);
 
+  if (added.size() > 1) {
+    // Some tests create a standalone window to anchor a dialog. In those cases,
+    // ignore added Widgets that are not dialogs.
+    base::EraseIf(added, [](views::Widget* widget) {

[Peter Kasting, 2017/03/10 08:29:54]

Nice use of this API that just went in!  I think you may be the first user.

+      return !widget->widget_delegate()->AsDialogDelegate();
+    });
+  }
+
   // This can fail if no dialog was shown, if the dialog shown wasn't a toolkit-
   // views dialog, or if more than one child dialog was shown.
   ASSERT_EQ(1u, added.size());
 
   const DialogAction action = base::CommandLine::ForCurrentProcess()->HasSwitch(
                                   internal::kInteractiveSwitch)
                                   ? DialogAction::INTERACTIVE
                                   : DialogAction::CLOSE_NOW;
 
   WidgetCloser closer(added[0], action);
   ::test::RunTestInteractively();
 }