components/nacl/browser/test_nacl_browser_delegate.h - Issue 2630443003: Add thread checks to NaClBrowser, and make it leaky

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/nacl/browser/test_nacl_browser_delegate.h

Issue 2630443003: Add thread checks to NaClBrowser, and make it leaky (Closed)

Patch Set: Move SetDelegate(nullptr) to ClearAndDeleteDelegateForTest() Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/nacl/browser/test_nacl_browser_delegate.h

diff --git a/components/nacl/browser/test_nacl_browser_delegate.h b/components/nacl/browser/test_nacl_browser_delegate.h

index 0894c828eea88d370f10fe2780e6b445a6e56705..58033401db904cd0532f1953878cfe5d57b10b85 100644

--- a/components/nacl/browser/test_nacl_browser_delegate.h

+++ b/components/nacl/browser/test_nacl_browser_delegate.h

@@ -17,7 +17,7 @@

// and

-// NaClBrowser::SetDelegate(NULL); // frees the test delegate.

+// NaClBrowser::ClearAndDeleteDelegateForTest();

class TestNaClBrowserDelegate : public NaClBrowserDelegate {

public:

TestNaClBrowserDelegate();