Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5077)

Unified Diff: chrome/browser/nacl_host/test/gdb_debug_stub_browsertest.cc

Issue 2630443003: Add thread checks to NaClBrowser, and make it leaky (Closed)
Patch Set: Update NaClGdbDebugStubTest Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/nacl_host/test/gdb_debug_stub_browsertest.cc
diff --git a/chrome/browser/nacl_host/test/gdb_debug_stub_browsertest.cc b/chrome/browser/nacl_host/test/gdb_debug_stub_browsertest.cc
index 2fc111a9334cfe1419aedd424b8ba4d8ca1095ab..ae6f09715ba7c9ee08a5dc2f450b4d80f23aeeea 100644
--- a/chrome/browser/nacl_host/test/gdb_debug_stub_browsertest.cc
+++ b/chrome/browser/nacl_host/test/gdb_debug_stub_browsertest.cc
@@ -54,14 +54,14 @@ void NaClGdbDebugStubTest::RunDebugStubTest(const std::string& nacl_module,
const std::string& test_name) {
base::Process test_script;
std::unique_ptr<base::Environment> env(base::Environment::Create());
- nacl::NaClBrowser::GetInstance()->SetGdbDebugStubPortListener(
- base::Bind(&NaClGdbDebugStubTest::StartTestScript,
- base::Unretained(this), &test_script, test_name));
+ nacl::NaClBrowser::SetGdbDebugStubPortListenerForTest(
+ base::Bind(&NaClGdbDebugStubTest::StartTestScript, base::Unretained(this),
+ &test_script, test_name));
// Turn on debug stub logging.
env->SetVar("NACLVERBOSITY", "1");
RunTestViaHTTP(nacl_module);
env->UnSetVar("NACLVERBOSITY");
- nacl::NaClBrowser::GetInstance()->ClearGdbDebugStubPortListener();
+ nacl::NaClBrowser::ClearGdbDebugStubPortListenerForTest();
int exit_code;
test_script.WaitForExit(&exit_code);
EXPECT_EQ(0, exit_code);

Powered by Google App Engine
This is Rietveld 408576698