Add thread checks to NaClBrowser, and make it leaky

components/nacl/browser/nacl_browser.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_NACL_BROWSER_NACL_BROWSER_H_
 #define COMPONENTS_NACL_BROWSER_NACL_BROWSER_H_
 
 #include <stdint.h>
 
 #include <deque>
 #include <memory>
 
 #include "base/bind.h"
 #include "base/containers/mru_cache.h"
 #include "base/files/file.h"
 #include "base/macros.h"
-#include "base/memory/singleton.h"
-#include "base/memory/weak_ptr.h"
 #include "base/time/time.h"
 #include "build/build_config.h"
 #include "components/nacl/browser/nacl_browser_delegate.h"
 #include "components/nacl/browser/nacl_validation_cache.h"
 
 namespace base {
 class FileProxy;
 }
 
 namespace nacl {
@@ skipping 30 matching lines @@
   // the public interface, however, so the IRT can be explicitly opened as
   // early as possible to prevent autoupdate issues.
   void EnsureIrtAvailable();
 
   // Path to IRT. Available even before IRT is loaded.
   const base::FilePath& GetIrtFilePath();
 
   // IRT file handle, only available when IsReady().
   const base::File& IrtFile() const;
 
-  // Methods for testing GDB debug stub in browser. If test adds debug stub
-  // port listener, Chrome will allocate a currently-unused TCP port number for
-  // debug stub server instead of a fixed one.
+  // Methods for tracking the GDB debug stub port associated with each NaCl
+  // process.
+  void SetProcessGdbDebugStubPort(int process_id, int port);
+  int GetProcessGdbDebugStubPort(int process_id);
 
-  // Notify listener that new debug stub TCP port is allocated.
-  void SetProcessGdbDebugStubPort(int process_id, int port);
-  void SetGdbDebugStubPortListener(base::Callback<void(int)> listener);
-  void ClearGdbDebugStubPortListener();
-
-  int GetProcessGdbDebugStubPort(int process_id);
+  // While a test has a GDB debug port callback set, Chrome will allocate a
+  // currently-unused TCP port to the debug stub server, instead of a fixed
+  // one.
+  void SetGdbDebugStubPortListenerForTest(base::Callback<void(int)> listener);
+  void ClearGdbDebugStubPortListenerForTest();
 
   enum ValidationCacheStatus {
     CACHE_MISS = 0,
     CACHE_HIT,
     CACHE_MAX
   };
 
   bool ValidationCacheIsEnabled() const {
     return validation_cache_is_enabled_;
   }
 
   const std::string& GetValidationCacheKey() const {
     return validation_cache_.GetValidationCacheKey();
   }
 
-  // The NaCl singleton keeps information about NaCl executable files opened via
+  // The instance keeps information about NaCl executable files opened via
   // PPAPI.  This allows the NaCl process to get trusted information about the
   // file directly from the browser process.  In theory, a compromised renderer
   // could provide a writable file handle or lie about the file's path.  If we
   // trusted the handle was read only but it was not, an mmapped file could be
   // modified after validation, allowing an escape from the NaCl sandbox.
   // Similarly, if we trusted the file path corresponded to the file handle but
   // it did not, the validation cache could be tricked into bypassing validation
   // for bad code.
   // Instead of allowing these attacks, the NaCl process only trusts information
   // it gets directly from the browser process.  Because the information is
@@ skipping 17 matching lines @@
   bool QueryKnownToValidate(const std::string& signature, bool off_the_record);
   void SetKnownToValidate(const std::string& signature, bool off_the_record);
   void ClearValidationCache(const base::Closure& callback);
 #if defined(OS_WIN)
   // Get path to NaCl loader on the filesystem if possible.
   // |exe_path| does not change if the method fails.
   bool GetNaCl64ExePath(base::FilePath* exe_path);
 #endif
 
   void EarlyStartup();
-  static void SetDelegate(NaClBrowserDelegate* delegate);
+
+  // Set/get the NaClBrowserDelegate. The |delegate| must be set at startup,
+  // from the Browser's UI thread. It will be leaked at browser teardown.
+  static void SetDelegate(std::unique_ptr<NaClBrowserDelegate> delegate);
   static NaClBrowserDelegate* GetDelegate();
+  static void ClearAndDeleteDelegateForTest();
 
-  // Each time a NaCl process ends, the browser is notified.
+  // Called whenever a NaCl process exits.
   void OnProcessEnd(int process_id);
-  // Support for NaCl crash throttling.
-  // Each time a NaCl module crashes, the browser is notified.
+
+  // Called whenever a NaCl process crashes, before OnProcessEnd().
   void OnProcessCrashed();
+
   // If "too many" crashes occur within a given time period, NaCl is throttled
   // until the rate again drops below the threshold.
   bool IsThrottled();
 
  private:
-  friend struct base::DefaultSingletonTraits<NaClBrowser>;
-
   enum NaClResourceState {
     NaClResourceUninitialized,
     NaClResourceRequested,
     NaClResourceReady
   };
 
   NaClBrowser();
   ~NaClBrowser();
 
   void InitIrtFilePath();
@@ skipping 10 matching lines @@
 
   // Dispatch waiting tasks if we are ready, or if we know we'll never be ready.
   void CheckWaiting();
 
   // Indicate that it is impossible to launch a NaCl process.
   void MarkAsFailed();
 
   void MarkValidationCacheAsModified();
   void PersistValidationCache();
 
-
   base::File irt_file_;
   base::FilePath irt_filepath_;
   NaClResourceState irt_state_;
   NaClValidationCache validation_cache_;
   NaClValidationCache off_the_record_validation_cache_;
   base::FilePath validation_cache_file_path_;
   bool validation_cache_is_enabled_;
   bool validation_cache_is_modified_;
   NaClResourceState validation_cache_state_;
   base::Callback<void(int)> debug_stub_port_listener_;
 
   // Map from process id to debug stub port if any.
   typedef std::map<int, int> GdbDebugStubPortMap;
   GdbDebugStubPortMap gdb_debug_stub_port_map_;
 
   typedef base::HashingMRUCache<std::string, base::FilePath> PathCacheType;
   PathCacheType path_cache_;
 
-  bool ok_;
+  // True if it is no longer possible to launch NaCl processes.
+  bool has_failed_;
 
   // A list of pending tasks to start NaCl processes.
   std::vector<base::Closure> waiting_;
 
-  std::unique_ptr<NaClBrowserDelegate> browser_delegate_;
-
   std::deque<base::Time> crash_times_;
 
-  // Singletons get destroyed at shutdown.
-  base::WeakPtrFactory<NaClBrowser> weak_factory_;
-
   DISALLOW_COPY_AND_ASSIGN(NaClBrowser);
 };
 
 } // namespace nacl
 
 #endif  // COMPONENTS_NACL_BROWSER_NACL_BROWSER_H_