Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1748)

Unified Diff: appengine/findit/model/flake/test/master_flake_analysis_test.py

Issue 2630433002: Findit] Flake Checker: Pipeline to trigger try jobs to identify flake culprits (Closed)
Patch Set: Addressing comments Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: appengine/findit/model/flake/test/master_flake_analysis_test.py
diff --git a/appengine/findit/model/flake/test/master_flake_analysis_test.py b/appengine/findit/model/flake/test/master_flake_analysis_test.py
index 39abb505be37d545954a012837ea5a143e57ab32..2fd5ad0205aa98c8b3542564c64c01ee095aa59d 100644
--- a/appengine/findit/model/flake/test/master_flake_analysis_test.py
+++ b/appengine/findit/model/flake/test/master_flake_analysis_test.py
@@ -189,4 +189,22 @@ class MasterFlakeAnalysisTest(TestCase):
self.assertIsNone(analysis.GetDataPointOfSuspectedBuild())
+ def testGetCommitPosition(self):
+ data_point = DataPoint()
+ data_point.blame_list = ['r1', 'r2', 'r3']
+ data_point.commit_position = 100
+ data_point.previous_build_commit_position = 97
+
+ self.assertEqual(98, data_point.GetCommitPosition('r1'))
+ self.assertEqual(99, data_point.GetCommitPosition('r2'))
+ self.assertEqual(100, data_point.GetCommitPosition('r3'))
+
+ def testGetRevisionAtCommitPosition(self):
+ data_point = DataPoint()
+ data_point.blame_list = ['r1', 'r2', 'r3']
+ data_point.commit_position = 100
+ data_point.previous_build_commit_position = 97
+ self.assertEqual('r1', data_point.GetRevisionAtCommitPosition(98))
+ self.assertEqual('r2', data_point.GetRevisionAtCommitPosition(99))
+ self.assertEqual('r3', data_point.GetRevisionAtCommitPosition(100))

Powered by Google App Engine
This is Rietveld 408576698