test/cctest/asmjs/test-asm-typer.cc - Issue 2630343002: [Parser] Introduce AstStringConstants to share constants across AstValueFactory

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: test/cctest/asmjs/test-asm-typer.cc

Issue 2630343002: [Parser] Introduce AstStringConstants to share constants across AstValueFactory (Closed)

Patch Set: Fix test Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: test/cctest/asmjs/test-asm-typer.cc

diff --git a/test/cctest/asmjs/test-asm-typer.cc b/test/cctest/asmjs/test-asm-typer.cc

index a0db745e970139c512d3abfbcae1de242d67da27..892c968d1d3e0ebb48fd036dec23c2aece3e87db 100644

--- a/test/cctest/asmjs/test-asm-typer.cc

+++ b/test/cctest/asmjs/test-asm-typer.cc

@@ -47,7 +47,8 @@ class AsmTyperHarnessBuilder {

handles_(),

zone_(handles_.main_zone()),

isolate_(CcTest::i_isolate()),

- ast_value_factory_(zone_, isolate_->heap()->HashSeed()),

+ ast_value_factory_(zone_, isolate_->ast_string_constants(),

+ isolate_->heap()->HashSeed()),

factory_(isolate_->factory()),

source_code_(

factory_->NewStringFromUtf8(CStrVector(source)).ToHandleChecked()),

« no previous file with comments | « src/parsing/parser.cc ('k') | test/cctest/test-ast.cc » ('j') | no next file with comments »