src/ast/ast-value-factory.cc - Issue 2630343002: [Parser] Introduce AstStringConstants to share constants across AstValueFactory

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/ast/ast-value-factory.cc

Issue 2630343002: [Parser] Introduce AstStringConstants to share constants across AstValueFactory (Closed)

Patch Set: Fix test Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/ast/ast-value-factory.cc

diff --git a/src/ast/ast-value-factory.cc b/src/ast/ast-value-factory.cc

index 8ea70872cc9eb890bd6f446278919c09ee0d3d92..4add57955fab4078492593b1c07ee17a653478bd 100644

--- a/src/ast/ast-value-factory.cc

+++ b/src/ast/ast-value-factory.cc

@@ -221,7 +221,6 @@ void AstValue::Internalize(Isolate* isolate) {

}

AstRawString* AstValueFactory::GetOneByteStringInternal(

Vector<const uint8_t> literal) {

if (literal.length() == 1 && IsInRange(literal[0], 'a', 'z')) {

« no previous file with comments | « src/ast/ast-value-factory.h ('k') | src/heap-symbols.h » ('j') | no next file with comments »