[Parser] Introduce AstStringConstants to share constants across AstValueFactory

test/cctest/test-ast.cc

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 12 matching lines @@
 // DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
 // THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
 // (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
 
 #include <stdlib.h>
 
 #include "src/v8.h"
 
 #include "src/ast/ast.h"
+#include "src/isolate.h"
 #include "src/objects-inl.h"
 #include "src/zone/accounting-allocator.h"
 #include "test/cctest/cctest.h"
 
 using namespace v8::internal;
 
 TEST(List) {
+  v8::V8::Initialize();
+  Isolate* isolate = CcTest::i_isolate();
+
   List<AstNode*>* list = new List<AstNode*>(0);
   CHECK_EQ(0, list->length());
 
   v8::internal::AccountingAllocator allocator;
   Zone zone(&allocator, ZONE_NAME);
-  AstValueFactory value_factory(&zone, 0);
+  AstValueFactory value_factory(&zone, isolate->ast_string_constants(),
+                                isolate->heap()->HashSeed());
   AstNodeFactory factory(&value_factory);
   AstNode* node = factory.NewEmptyStatement(kNoSourcePosition);
   list->Add(node);
   CHECK_EQ(1, list->length());
   CHECK_EQ(node, list->at(0));
   CHECK_EQ(node, list->last());
 
   const int kElements = 100;
   for (int i = 0; i < kElements; i++) {
     list->Add(node);
   }
   CHECK_EQ(1 + kElements, list->length());
 
   list->Clear();
   CHECK_EQ(0, list->length());
   delete list;
 }