[Devtools] Accessibility pane: correctly show label text source

third_party/WebKit/Source/devtools/front_end/accessibility/AccessibilityNodeView.js

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 /**
  * @unrestricted
  */
 Accessibility.AXNodeSubPane = class extends Accessibility.AccessibilitySubPane {
   constructor() {
     super(Common.UIString('Computed Properties'));
 
@@ skipping 170 matching lines @@
     } else {
       nameElement.textContent = name;
       nameElement.classList.add('ax-name');
       nameElement.classList.add('monospace');
     }
     this.listItemElement.appendChild(nameElement);
   }
 
   /**
    * @param {!Protocol.Accessibility.AXValue} value
-   * @return {?Element}
    */
   appendValueElement(value) {
     var AXValueType = Protocol.Accessibility.AXValueType;
     if (value.type === AXValueType.Idref || value.type === AXValueType.Node || value.type === AXValueType.IdrefList ||
         value.type === AXValueType.NodeList) {
       this.appendRelatedNodeListValueElement(value);
-      if (!value.value)
-        return null;
+      return;
     } else if (value.sources) {
       var sources = value.sources;
       for (var i = 0; i < sources.length; i++) {
         var source = sources[i];
         var child = new Accessibility.AXValueSourceTreeElement(source, this._axNode);
         this.appendChild(child);
       }
       this.expand();
     }
     var element = Accessibility.AXNodePropertyTreeElement.createSimpleValueElement(value.type, String(value.value));
     this.listItemElement.appendChild(element);
-    return element;
   }
 
   /**
    * @param {!Protocol.Accessibility.AXRelatedNode} relatedNode
    * @param {number} index
    */
   appendRelatedNode(relatedNode, index) {
     var deferredNode = new SDK.DeferredDOMNode(this._axNode.target(), relatedNode.backendDOMNodeId);
     var nodeTreeElement = new Accessibility.AXRelatedNodeSourceTreeElement({deferredNode: deferredNode}, relatedNode);
     this.appendChild(nodeTreeElement);
@@ skipping 74 matching lines @@
     this._update();
   }
 
   _update() {
     this.listItemElement.removeChildren();
 
     this.appendNameElement(this._property.name);
 
     this.listItemElement.createChild('span', 'separator').textContent = ':\u00A0';
 
-    var valueElement = this.appendValueElement(this._property.value);
-    if (this._property.name === 'name')
-      valueElement.classList.add('ax-computed-text');
+    this.appendValueElement(this._property.value);
   }
 };
 
 /**
  * @unrestricted
  */
 Accessibility.AXValueSourceTreeElement = class extends Accessibility.AXNodePropertyTreeElement {
   /**
    * @param {!Protocol.Accessibility.AXValueSource} source
    * @param {!Accessibility.AccessibilityNode} axNode
@@ skipping 124 matching lines @@
     this.appendSourceNameElement(this._source);
 
     this.listItemElement.createChild('span', 'separator').textContent = ':\u00a0';
 
     if (this._source.attributeValue) {
       this.appendValueElement(this._source.attributeValue);
       this.listItemElement.createTextChild('\u00a0');
     } else if (this._source.nativeSourceValue) {
       this.appendValueElement(this._source.nativeSourceValue);
       this.listItemElement.createTextChild('\u00a0');
+      if (this._source.value)
+        this.appendValueElement(this._source.value);
     } else if (this._source.value) {
       this.appendValueElement(this._source.value);
     } else {
       var valueElement = Accessibility.AXNodePropertyTreeElement.createSimpleValueElement(
           Protocol.Accessibility.AXValueType.ValueUndefined, Common.UIString('Not specified'));
       this.listItemElement.appendChild(valueElement);
       this.listItemElement.classList.add('ax-value-source-unused');
     }
 
     if (this._source.value && this._source.superseded)
       this.listItemElement.classList.add('ax-value-source-superseded');
   }
-
-  /**
-   * @param {!Protocol.Accessibility.AXValue} value
-   * @return {!Element}
-   * @override
-   */
-  appendValueElement(value) {
-    var element = super.appendValueElement(value);
-    if (!element) {
-      element = Accessibility.AXNodePropertyTreeElement.createSimpleValueElement(value.type, String(value.value));
-      this.listItemElement.appendChild(element);
-    }
-    return element;
-  }
 };
 
 /**
  * @unrestricted
  */
 Accessibility.AXRelatedNodeSourceTreeElement = class extends UI.TreeElement {
   /**
    * @param {{deferredNode: (!SDK.DeferredDOMNode|undefined), idref: (string|undefined)}} node
    * @param {!Protocol.Accessibility.AXRelatedNode=} value
    */
@@ skipping 159 matching lines @@
 
     this._reasonElement =
         Accessibility.AXNodeIgnoredReasonTreeElement.createReasonElement(this._property.name, this._axNode);
     this.listItemElement.appendChild(this._reasonElement);
 
     var value = this._property.value;
     if (value.type === Protocol.Accessibility.AXValueType.Idref)
       this.appendRelatedNodeListValueElement(value);
   }
 };